MODINV-1066: Update mapping for "sourceRecordIdentifier" property in … #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBobylev
requested review from
AndreiBordak,
KaterynaSenchenko,
pkjacob and
askhat-abishev
AndreiBordak
approved these changes
Aug 21, 2024
pkjacob
approved these changes
Aug 21, 2024
|
Hi @PBobylev, We should not merge this to "master" branch right? If we merge "beta" will break (because mod-linked-data will be sending instance ID in sourceRecordId field and mod-inventory is expecting instance ID in "additionalProperties -> instanceID" field. |
askhat-abishev
approved these changes
Aug 23, 2024
KaterynaSenchenko
approved these changes
Aug 29, 2024
pkjacob
approved these changes
Sep 4, 2024
…"instance_ingress" event
PBobylev
force-pushed
the
MODINV-1066
branch
from
d37ba51 to
a060011
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…"instance_ingress" event