[MODINVSTOR-1243] Implement endpoint to retrieve items from multiple tenants #755
Conversation
Saba-Zedginidze-EPAM
force-pushed
the
MODINVSTOR-1243
branch
from
df09026 to
fbdc18a
Compare
Saba-Zedginidze-EPAM
force-pushed
the
MODINVSTOR-1243
branch
from
1244692 to
e957735
Compare
Saba-Zedginidze-EPAM
force-pushed
the
MODINVSTOR-1243
branch
from
a574fd7 to
d135a4e
Compare
SerhiiNosko
requested review from
a team,
azizbekxm,
BKadirkhodjaev and
SerhiiNosko
|
| return List.of(); | ||
| } | ||
| return JsonArrayHelper.toList(response.getJson(), ITEMS_FIELD).stream() | ||
| .map(item -> item.put(TENANT_ID_FIELD, tenantId)) |
There was a problem hiding this comment.
could you say why "tenantId" field is set to the item json? Looks like it does not comply with the response definition because the item schema does not contain "tenantId" field.
There was a problem hiding this comment.
In screen from testing I see that response object has tenantId populated:
Maybe Item object allows to add properties dynamically
There was a problem hiding this comment.
the field "tenantId" successfully has been added to response because in the code we set it to JsonObject representing item and that allows to add any property
There was a problem hiding this comment.
do you think we can improve this in some way, for example by adding tenantId to Item schema explicitly?
There was a problem hiding this comment.
I suppose yes, or maybe to add a new response schema for this endpoint that would refer to the item schema
Purpose
[MODINVSTOR-1243] Implement endpoint to retrieve items from multiple tenants
Approach
Screenshots
Verified and left comment on JIRA ticket: https://folio-org.atlassian.net/browse/MODINVSTOR-1243?focusedCommentId=226464