Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODINV-1125: Fix handling Optimistic Locking error and retry mechanism on Instance update #799

Merged
merged 7 commits into from
Jan 22, 2025
Merged

MODINV-1125: Fix handling Optimistic Locking error and retry mechanism on Instance update #799

merged 7 commits into from
Jan 22, 2025

Conversation

mukhiddin-yusuf
Copy link
Contributor

@mukhiddin-yusuf mukhiddin-yusuf commented Jan 9, 2025 •
edited
Loading

Purpose

Fix handling optimistic locking error on updating inventory instance record while handling Marc Bib Update event and implement proper retry mechanism

Approach

Do not wrap OptimisticLocking error inside the other one so that it is possible to handle it in the Marc Bib update event handler

Changes Checklist

  • Logging: Confirm that logging is appropriately handled.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • Integration Testing: Confirm the logic in covered by integration testing

MODINV-1125
MODSOURCE-832
MODELINKS-286

@mukhiddin-yusuf mukhiddin-yusuf requested a review from a team January 9, 2025 11:36
@mukhiddin-yusuf mukhiddin-yusuf self-assigned this Jan 9, 2025
@mukhiddin-yusuf mukhiddin-yusuf requested review from psmagin, viacheslavkol and SvitlanaKovalova1 and removed request for a team January 9, 2025 11:36
@mukhiddin-yusuf mukhiddin-yusuf requested a review from a team January 22, 2025 09:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
59.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@mukhiddin-yusuf mukhiddin-yusuf merged commit 8c49f56 into master Jan 22, 2025
3 of 4 checks passed
@mukhiddin-yusuf mukhiddin-yusuf deleted the modinv-1125 branch January 22, 2025 12:56
mukhiddin-yusuf added a commit that referenced this pull request Jan 23, 2025
@mukhiddin-yusuf
MODINV-1125: Fix handling Optimistic Locking error and retry mechanis…
2dd95f7 
…m on Instance update (#799)

* MODINV-1125: fix handling optimistic locking error and retry mechanism on instance update
mukhiddin-yusuf added a commit that referenced this pull request Jan 27, 2025
@mukhiddin-yusuf
MODINV-1125: Fix handling Optimistic Locking error and retry mechanis…
d12be36 
…m on Instance update (#799)
mukhiddin-yusuf added a commit that referenced this pull request Jan 28, 2025
@mukhiddin-yusuf
Release v20.2.11: MODINV-1125 - Fix handling optimistic locking behav…
ff08492 
…ior for instance update when consuming Marc Bib update event (#808)

* MODINV-1125: Fix handling Optimistic Locking error and retry mechanism on Instance update (#799)

* [maven-release-plugin] prepare release v20.2.11

* [maven-release-plugin] prepare for next development iteration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvitlanaKovalova1 SvitlanaKovalova1 SvitlanaKovalova1 approved these changes

@viacheslavkol viacheslavkol viacheslavkol approved these changes

@VRohach VRohach VRohach approved these changes

@psmagin psmagin psmagin approved these changes

Assignees

@mukhiddin-yusuf mukhiddin-yusuf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mukhiddin-yusuf @psmagin @VRohach @viacheslavkol @SvitlanaKovalova1