MODLD-646: Update the response structure of authorityAssignmentCheck API #104
+32
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askhat-abishev
approved these changes
Jan 29, 2025
PBobylev
requested changes
Jan 29, 2025
| @@ -267,8 +267,7 @@ paths: | |||
| content: | |||
| text/plain: | |||
There was a problem hiding this comment.
Now it should be application/json, right?
Description is outdated too (line 266)
| "reason": { | ||
| "type": "string", | ||
| "enum": ["UNSUPPORTED_MARC", "NO_LCCN", "NOT_VALID_FOR_TARGET"], | ||
| "description": "Indicates the reason why the assignment is not valid. Only present if 'validAssignment' is false." |
There was a problem hiding this comment.
Such description makes me feel that parameter name isn't so descriptive.
What if we name it like invalidationReason or smth?
There was a problem hiding this comment.
Good point. Copilot suggested the name 'invalidAssignmentReason'. So, I used it :)
pkjacob
force-pushed
the
pjacob/MODLD-646
branch
from
5fdbd75 to
bc53fb6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged along with folio-org/ui-linked-data#84