MODLD-602 & FOLIO-3678: Use GitHub Workflows api-lint and api-schema-lint and api-doc #52
Conversation
pkjacob
requested review from
PBobylev,
AndreiBordak,
askhat-abishev and
dcrossleyau
|
The "API_EXCLUDES" is incorrect for both api-lint.yml and api-doc.yml -- it is "file name", so remove the path component. That exclusion is not needed in api-schema-lint.yml because it processes JSON files only. I do not know anything about these modified Workflows that mod-search has made to the defaults linked from https://dev.folio.org/guides/api-doc/#github-workflows (i.e. those at https://github.com/folio-org/.github/tree/master/workflow-templates). So if there are issues then you will need assistance from them. Note that these mod-linked-data workflow files are not those that you say that you utilised from my original mod-search PR 363. Also i see that the "on ... paths" triggers have been removed. Also remember that the main issue described at MODLD-602 (Invalid JSON pointer) will also arise here. You should activate the workflows on this branch. With my original PR i did that via an inconsequential edit to an API description file. But that will be ineffective here because you have removed the triggers for api-lint and api-schema-lint Workflows. |
|
Thank you for the feedback @dcrossleyau. I didn't realize that mod-search team deviated from the original templates in https://github.com/folio-org/.github/tree/master/workflow-templates. I have updated the PR to use the original templates. Please take a look. I added an empty line in mod-linked-data.yml based on the following line in your comment. Is it really needed?
|
pkjacob
force-pushed
the
pjacob/MODLD-602
branch
from
d53abc6 to
e144d5c
Compare
|
Making similar changes as in folio-org/mod-search#363