MODLD-643: Preservation of MARC fields that are not rendered in the UI #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkjacob
reviewed
Jan 17, 2025
| content jsonb null | ||
| ); | ||
|
|
||
| comment on table raw_marcs is 'Stores MARC records associated with LD resources'; |
There was a problem hiding this comment.
Let us change the comment to Store unmapped MARC records associated with an Instance resource. Applicable only for Instance resources
pkjacob
reviewed
Jan 17, 2025
| @@ -102,6 +102,10 @@ public class Resource implements Persistable<Long> { | |||
| @PrimaryKeyJoinColumn | |||
| private FolioMetadata folioMetadata; | |||
|
|
|||
| @OneToOne(cascade = ALL, mappedBy = "resource", orphanRemoval = true) | |||
| @PrimaryKeyJoinColumn | |||
| private RawMarc rawMarc; | |||
There was a problem hiding this comment.
Let us rename this field to unmappedMarcFields (or unmappedMarc)
pkjacob
approved these changes
Jan 21, 2025
askhat-abishev
force-pushed
the
MODLD-643
branch
2 times, most recently
from
e62db38 to
1894a3d
Compare
PBobylev
approved these changes
Jan 27, 2025
askhat-abishev
force-pushed
the
MODLD-643
branch
from
1894a3d to
e23a2db
Compare
askhat-abishev
force-pushed
the
MODLD-643
branch
from
e23a2db to
a1b46fc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.