[MODORDERS-1159-2]. Add validation for pieces without item, add missi…

…ng delete permission (#997)
folio-org · Aug 16, 2024 · fd15c05 · fd15c05
1 parent 9d3ebce
commit fd15c05
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/descriptors/ModuleDescriptor-template.json b/descriptors/ModuleDescriptor-template.json
@@ -412,6 +412,7 @@
             "inventory.items.collection.get",
             "inventory.items.item.put",
             "inventory.items.item.post",
+            "inventory.items.item.delete",
             "inventory-storage.holdings.collection.get",
             "inventory-storage.holdings-sources.collection.get",
             "inventory-storage.holdings.item.post",

diff --git a/src/main/java/org/folio/helper/CheckinHelper.java b/src/main/java/org/folio/helper/CheckinHelper.java
@@ -5,6 +5,7 @@
 import io.vertx.core.Promise;
 import io.vertx.core.json.JsonArray;
 import io.vertx.core.json.JsonObject;
+import java.util.Objects;
 import one.util.streamex.StreamEx;
 import org.apache.commons.collections4.CollectionUtils;
 import org.apache.commons.lang3.StringUtils;
@@ -96,7 +97,7 @@ private Future<Map<String, List<Piece>>> createItemsWithPieceUpdate(CheckinColle
                 .map(PoLineCommonUtil::convertToCompositePoLine)
                 .compose(compPol -> pieceCreateFlowInventoryManager.processInventory(compPol, piece, checkInPiece.getCreateItem(), requestContext))
                 .map(voidResult -> new PiecesHolder.PiecePoLineDto(poLineId, piece)));
-            } else if (checkInPiece.getId().equals(piece.getId()) && InventoryUtils.allowItemRecreate(srcTenantId, dstTenantId)) {
+            } else if (checkInPiece.getId().equals(piece.getId()) && InventoryUtils.allowItemRecreate(srcTenantId, dstTenantId) && Objects.nonNull(piece.getItemId())) {
               pieceFutures.add(purchaseOrderLineService.getOrderLineById(poLineId, requestContext)
                 .map(PoLineCommonUtil::convertToCompositePoLine)
                 .map(compPol -> new PiecesHolder.PiecePoLineDto(compPol, piece, checkInPiece)));