Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODORDERS-1143] Paying an invoice reopens the order #1025

Merged
merged 12 commits into from
Sep 23, 2024
Merged

[MODORDERS-1143] Paying an invoice reopens the order #1025

merged 12 commits into from
Sep 23, 2024

Conversation

Saba-Zedginidze-EPAM
Copy link
Contributor

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM commented Sep 19, 2024 •
edited
Loading

Purpose

[MODORDERS-1143] Paying an invoice reopens the order

Approach

  • Minor refactoring for exising helper code
  • Prevent order reopen when playing invoice

Karate Tests

OrdersApiTest

image

ConsortiaOrdersApiTest

image

CrossModulesApiTest

image

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM requested a review from a team September 20, 2024 10:50
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM merged commit 08a60f6 into master Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azizbekxm azizbekxm azizbekxm approved these changes

@SerhiiNosko SerhiiNosko SerhiiNosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saba-Zedginidze-EPAM @SerhiiNosko @azizbekxm