[EUREKA-561-4]. Add validateUserUnaffiliatedLocationUpdates method to Order Open/unopen #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Order Open/unopen
SerhiiNosko
reviewed
Dec 6, 2024
SerhiiNosko
reviewed
Dec 6, 2024
SerhiiNosko
reviewed
Dec 6, 2024
SerhiiNosko
reviewed
Dec 6, 2024
src/main/java/org/folio/service/orders/CompositePoLineValidationService.java
Outdated
Show resolved
Hide resolved
SerhiiNosko
approved these changes
Dec 6, 2024
|
SerhiiNosko
added a commit
that referenced
this pull request
Dec 11, 2024
* [EUREKA-561-2]. (ECS) Can open/unopen order with PO line locations from tenant in which user does not have affiliation (#1057) * [EUREKA-561-2]. (ECS) Can open/unopen order with PO line locations from tenant in which user does not have affiliation * [EUREKA-561-2]. Update acq-models * [EUREKA-561-2]. Update acq-models * [EUREKA-561-2]. Update logs * [EUREKA-561-2]. Apply recommendations (cherry picked from commit 4fc7f1b) * [EUREKA-561-4]. Add validateUserUnaffiliatedLocationUpdates method to Order Open/unopen (#1061) * [EUREKA-561-3]. Add validateUserUnaffiliatedLocationUpdates method to Order Open/unopen * [EUREKA-561-4]. Change method args & remove risky conversions * [EUREKA-561-4]. Replace filtering with StringUtils.equals(), change args names (cherry picked from commit 8092d97) * [EUREKA-561-5]. Simplify location validation, update tests (#1062) (cherry picked from commit 751ce1e) * Relase 12.9.4 Ramsons Bugfix * [MODORDERS-1222] - Error when trying to Unopen an ongoing order to add a purchase order line with multiple funds (#1063) * [MODORDERS-1222] - Error when trying to Unopen an ongoing order to add a purchase order line with multiple funds * Covered with test (cherry picked from commit a49c289) * Include one more ticket to Relase 12.9.4 Ramsons Bugfix * [maven-release-plugin] prepare release v12.9.4 * [maven-release-plugin] prepare for next development iteration --------- Co-authored-by: Boburbek Kadirkhodjaev <[email protected]> Co-authored-by: Azizbek Khushvakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approach
validateUserUnaffiliatedLocationUpdatestoupdateOrdermethod to guard against unaffiliated order opening/unopening