Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODORDERS-964] Update acq-models #806

Merged
merged 2 commits into from
Dec 19, 2023
Merged

[MODORDERS-964] Update acq-models #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a65e1c
Update acq-models
alb3rtino Nov 15, 2023
dd1c61f
Update provided and required interface versions
alb3rtino Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions descriptors/ModuleDescriptor-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"provides": [
{
"id": "orders",
"version": "12.0",
"version": "12.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I remember if we increase from 12.0 to 12.1 - Okapi will not throw an error, even if in mod-gobi required version is 12.0 https://github.com/folio-org/mod-gobi/blob/master/descriptors/ModuleDescriptor-template.json#L157
If we for example we increased from 12.0 to 13.0 and in mod-gobi remain 12.0 - Okapi will throw an error during enabling the module.
But you can check my words using karate tests(acquisition folder in folio-integration-test) or just locally.

Basically we not always follow the rule to update minor version when adding new field, but in case when you increased it also would be a good practice to increase in these modules as well:
https://github.com/folio-org/mod-invoice/blob/master/descriptors/ModuleDescriptor-template.json#L664
https://github.com/folio-org/mod-gobi/blob/master/descriptors/ModuleDescriptor-template.json#L157
https://github.com/folio-org/mod-ebsconet/blob/master/descriptors/ModuleDescriptor-template.json#L6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically I am ok to keep major versions for example in mod-gobi 12.0 and in orders increase to 12.1. It should work

"handlers": [
{
"methods": [
Expand Down Expand Up @@ -143,7 +143,7 @@
},
{
"id": "order-lines",
"version": "3.2",
"version": "3.3",
"handlers": [
{
"methods": [
Expand Down Expand Up @@ -1024,7 +1024,7 @@
},
{
"id": "orders-storage.purchase-orders",
"version": "8.0"
"version": "8.1"
},
{
"id": "orders-storage.alerts",
Expand All @@ -1044,7 +1044,7 @@
},
{
"id": "orders-storage.po-lines",
"version": "12.0"
"version": "12.3"
},
{
"id": "orders-storage.order-templates",
Expand Down
2 changes: 1 addition & 1 deletion ramls/acq-models
Open in desktop
Submodule acq-models updated 10 files
+3 −0 mod-orders-storage/examples/po_line_collection.sample
+3 −0 mod-orders-storage/examples/po_line_get.sample
+3 −0 mod-orders-storage/examples/purchase_order_collection.sample
+3 −0 mod-orders-storage/examples/purchase_order_get.sample
+5 −0 mod-orders-storage/schemas/po_line.json
+5 −0 mod-orders-storage/schemas/purchase_order.json
+3 −0 mod-orders/examples/composite_po_line.sample
+6 −0 mod-orders/examples/composite_purchase_order.sample
+5 −0 mod-orders/schemas/composite_po_line.json
+5 −0 mod-orders/schemas/composite_purchase_order.json