-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MODORDERS-989] - Placeholder - abiblity to move piece from Unrecivable into Expected #819
Conversation
|
||
import java.util.Map; | ||
|
||
public class RestoreHelper extends ReceivingHelper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doubt
By extending some class we inherit not only methods but state as well. Having global fields in service/helper classes is a separate issue but now we are adding a lot of compelcity on top. Let's use aggregation if possible:
RestoreHelper
can inject ReceivingHelper
.
import org.folio.rest.jaxrs.model.ReceivingResults; | ||
|
||
import java.util.Map; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets add java doc that this class is responsible to change staus from Unreciavable to Expected, because without context it is hard to understand
acdc689
to
254fb4f
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Purpose
Approach
TODOS and Open Questions
Learning
MODORDERS-989
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.