Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODORDERS-1026] - Implemented API to execute mod-template-engine request #874

Merged
merged 42 commits into from
Apr 4, 2024
Merged

[MODORDERS-1026] - Implemented API to execute mod-template-engine request #874

merged 42 commits into from
Apr 4, 2024

Conversation

azizbekxm
Copy link
Contributor

@azizbekxm azizbekxm commented Mar 28, 2024 •
edited
Loading

Purpose

https://folio-org.atlassian.net/browse/MODORDERS-1026

Approach

  • Fetched routing-list by id.
  • Fetching users by userIds of routing-list
  • Creating template-request
  • Executing request and forwarding response

Overall process : https://excalidraw.com/#json=obkLNEZh-lTWEnCbqLqQN,Hfkp0e-FXO1fsBOFp8xR4w

azizbekxm and others added 30 commits March 27, 2024 10:50
@azizbekxm
updated acq-model for routing list
c73fa3e
@azizbekxm
[MODORSERS-1026] - Implement API to execute mod-template-engine request
47ef021
@azizbekxm
[MODORSERS-1026] - Update permissions
9661f92
@azizbekxm
Merge branch 'master' into MODORDERS-1026
17a3b29
@azizbekxm
[MODORSERS-1026] - Fixed context issue
63766bc
@azizbekxm
[MODORSERS-1026] - Added RoutingList service to ApplicationConfig
75c4c08
@azizbekxm
[MODORSERS-1026] - Added UserService to ApplicationConfig
5326d4e
@azizbekxm
[MODORSERS-1026] - Implemented api to execute template-request api
1276445
@azizbekxm
[MODORSERS-1026] - Fixed logs issue
7dc0657
@azizbekxm
[MODORSERS-1026] - added hashcode in TemplateProcessingRequest
d83c8ab
@azizbekxm
[MODORSERS-1026] - Added jsonProperty annotation
48e3ee4
@azizbekxm
[MODORSERS-1026] - Added jsonProperty annotation
e94d73d
@azizbekxm
[MODORSERS-1026] - tmp log level changed
155ea13
@azizbekxm
[MODORSERS-1026] - Fixed jsonObject converting error
e12d91c
@azizbekxm
[MODORSERS-1026] - Fixed endpoint
15d5f35
@azizbekxm
[MODORSERS-1026] - Added tests
274616e
@azizbekxm
[MODORSERS-1026] - Fixed tests
413be73
@azizbekxm
Merge branch 'master' into MODORDERS-1026
31dc9c0
@azizbekxm
[MODORSERS-1026] - Improved template request context
6724613
@azizbekxm
Merge remote-tracking branch 'origin/MODORDERS-1026' into MODORDERS-1026
f7f467f
@azizbekxm
[MODORSERS-1026] - Improved template request context
b2a135f
@azizbekxm
[MODORSERS-1026] - Improved template request context
980c337
@azizbekxm
Merge branch 'master' into MODORDERS-1026
4390ef2
@azizbekxm
[MODORSERS-1026] - Changed api design
7e4980b
@azizbekxm
[MODORSERS-1026] - Fixed test
fa557e5
@azizbekxm
[MODORSERS-1026] - Updated descriptor
929aaba
@azizbekxm
[MODORSERS-1026] - Updated descriptor
7ff500a
@azizbekxm
[MODORSERS-1026] - Created dto object for userCollection
31888b9
@azizbekxm
[MODORSERS-1026] - Improved tests and fixed jsonObject issue
6a23713
@azizbekxm
[MODORSERS-1026] - Prepared to code-review
a301ec0
@azizbekxm azizbekxm marked this pull request as ready for review April 3, 2024 11:05
@azizbekxm azizbekxm requested a review from a team April 3, 2024 11:05
SerhiiNosko
SerhiiNosko reviewed Apr 3, 2024
View reviewed changes
descriptors/ModuleDescriptor-template.json
"orders.export-history.all"

"orders.export-history.all",
"orders.routing-list-template.item.get"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add this permission in routing-lists.all when this PR will be merged #879

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
90.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@azizbekxm
Copy link
Contributor Author

Tested on rancher:
image

@azizbekxm azizbekxm merged commit d74496e into master Apr 4, 2024
6 checks passed
@azizbekxm azizbekxm deleted the MODORDERS-1026 branch April 4, 2024 13:25
@SerhiiNosko SerhiiNosko mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM approved these changes

@SerhiiNosko SerhiiNosko SerhiiNosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azizbekxm @SerhiiNosko @Saba-Zedginidze-EPAM