Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODORDERS-1077 Data Import organisations not mapping #892

Merged
merged 12 commits into from
Apr 17, 2024

Conversation

dmytrokrutii
Copy link
Contributor

@dmytrokrutii dmytrokrutii commented Apr 12, 2024

Purpose

As part of the order creation, all organizations are retrieved from mod-organizations. However, this service returns data with duplicates, which causes the loss of about 1-2% of vendors when loading them into the cache.

Approach

Add a query parameter to sort vendors by id.

TODOS and Open Questions

Learning

MODORDERS-1077

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all the appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?
  • Did you modify code to call some additional endpoints?
    • If so, do you check that necessary module permission added in ModuleDescriptor-template.yaml file?

Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@dmytrokrutii dmytrokrutii marked this pull request as draft April 12, 2024 13:31
@dmytrokrutii dmytrokrutii changed the title Modorders 1077 MODORDERS-1077 Apr 15, 2024
@dmytrokrutii dmytrokrutii changed the title MODORDERS-1077 MODORDERS-1077 Data Import organisations not mapping Apr 15, 2024
@dmytrokrutii dmytrokrutii marked this pull request as ready for review April 15, 2024 15:28
@dmytrokrutii dmytrokrutii marked this pull request as draft April 16, 2024 09:16
@dmytrokrutii dmytrokrutii marked this pull request as ready for review April 16, 2024 13:27
Copy link
Contributor

@JavokhirAbdullayev JavokhirAbdullayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update news please

Copy link

@dmytrokrutii dmytrokrutii merged commit e9de034 into master Apr 17, 2024
6 checks passed
@dmytrokrutii dmytrokrutii deleted the MODORDERS-1077 branch April 17, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants