MODRTAC-88: Separate error message for not found instances #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcjohnson-kint
approved these changes
Jul 13, 2022
src/test/java/org/folio/rest/impl/RtacBatchResourceImplTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Johnson <[email protected]>
Co-authored-by: Marc Johnson <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the code in folioFacade that forms the response to requests.
I also modified the errorMapper class so that there are two separate error
messages for no holdings and no instance found.
Finally, I modified and created new tests to check for the new error messages.