-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cn-browse): support aliases for callNumberTypeId filters #733
Conversation
Closes: MSEARCH-942
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
var browseConfig = configService.getConfig(BrowseType.CALL_NUMBER, browseOptionType); | ||
return browseConfig.getTypeIds().stream().map(Object::toString).toArray(String[]::new); | ||
} catch (IllegalArgumentException e) { | ||
return inputTerm; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we need to log some message here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's expected flow. If the input is not parsed to the enum then we proceed with input without any changes.
So, I believe no log msg needed
Purpose
Support call-number browse option names as aliases for callNumberTypeId filters for call-number documents.
Approach
Add search term processor for call-number type id field.
Modify query construction for exact match term queries to support array of values.
Changes Checklist
Related Issues
https://folio-org.atlassian.net/browse/MSEARCH-942