Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cn-browse): support aliases for callNumberTypeId filters #733

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Jan 15, 2025

Purpose

Support call-number browse option names as aliases for callNumberTypeId filters for call-number documents.

Approach

Add search term processor for call-number type id field.
Modify query construction for exact match term queries to support array of values.

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MSEARCH-942

@psmagin psmagin changed the base branch from master to feature/call-number-browse-v2 January 15, 2025 14:46
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@psmagin psmagin marked this pull request as ready for review January 15, 2025 15:11
@psmagin psmagin requested a review from a team as a code owner January 15, 2025 15:11
@psmagin psmagin requested review from viacheslavkol, mukhiddin-yusuf and SvitlanaKovalova1 and removed request for a team January 15, 2025 15:11
@psmagin psmagin changed the title MSEARCH-942 feat(cn-browse): support aliases for callNumberTypeId filters Jan 15, 2025
var browseConfig = configService.getConfig(BrowseType.CALL_NUMBER, browseOptionType);
return browseConfig.getTypeIds().stream().map(Object::toString).toArray(String[]::new);
} catch (IllegalArgumentException e) {
return inputTerm;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need to log some message here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's expected flow. If the input is not parsed to the enum then we proceed with input without any changes.
So, I believe no log msg needed

@psmagin psmagin merged commit 346cef8 into feature/call-number-browse-v2 Jan 16, 2025
5 of 6 checks passed
@psmagin psmagin deleted the MSEARCH-942 branch January 16, 2025 10:53
psmagin added a commit that referenced this pull request Jan 17, 2025
psmagin added a commit that referenced this pull request Jan 21, 2025
psmagin added a commit that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants