Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(marc-fields-order): Fix bib fields order on link update event #662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(marc-fields-order): Fix bib fields order on link update event #662

wants to merge 1 commit into from
+72 −10

Conversation

viacheslavkol
Copy link
Contributor

Purpose

Fix bib fields order on link update event

Approach

  • Handle only authority natural id change
  • Put uncontroller alphabetic fields before controlled number fields

TODOS and Open Questions

  • Use GitHub checklists. When solved, check the box and explain the answer.
  • Check logging.

Learning

MODSOURCE-842

@viacheslavkol
fix(marc-fields-order): Fix bib fields order on link update event
509189e 
- Handle only authority natural id change
- Put uncontroller alphabetic fields before controlled number fields

Closes: MODSOURCE-842
@viacheslavkol viacheslavkol self-assigned this Jan 16, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@viacheslavkol viacheslavkol marked this pull request as ready for review January 16, 2025 11:54
@viacheslavkol viacheslavkol requested review from a team, psmagin, mukhiddin-yusuf and SvitlanaKovalova1 and removed request for a team January 16, 2025 11:54
psmagin
psmagin reviewed Jan 16, 2025
View reviewed changes
...cord-storage-server/src/main/java/org/folio/services/handlers/links/UpdateLinkProcessor.java
Comment on lines +30 to +31
var controllableAlphaSubfields = new ArrayList<Subfield>();
var controllableDigitSubfields = new ArrayList<Subfield>();
Copy link
Contributor

@psmagin psmagin Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was agreed to have this separation only for uncontrollable sufields. But controllable subfields should have same order as authority record.
Am I wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmagin psmagin psmagin left review comments

@mukhiddin-yusuf mukhiddin-yusuf mukhiddin-yusuf approved these changes

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 was automatically assigned from folio-org/spitfire-backend

Assignees

@viacheslavkol viacheslavkol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viacheslavkol @psmagin @mukhiddin-yusuf