Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RANCHER-2026: Create new pipeline "Update module" #784

Open
wants to merge 41 commits into
base: RANCHER-1334
Choose a base branch
from

Conversation

@yaroslavishchenko yaroslavishchenko self-assigned this Jan 20, 2025
@yaroslavishchenko yaroslavishchenko marked this pull request as ready for review January 20, 2025 11:53
@yaroslavishchenko yaroslavishchenko changed the title RANCHER-2024: add Jenkinsfile RANCHER-2026: Create new pipeline "Update module" Jan 22, 2025
module.descriptor = [readJSON(text: moduleDescriptor)]

// Upload Module Descriptor to Eureka Descriptor Registry
String putModuleDescriptorToRegistry = "curl -sS -X PUT ${Constants.EUREKA_REGISTRY_URL}${module.name}-${module.version} --data @- <<EOF\n${moduleDescriptor}\nEOF"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused and unrelated code for code ONLY.

import org.folio.rest_v2.eureka.Eureka
import org.jenkinsci.plugins.workflow.libs.Library

@Library('pipelines-shared-library@RANCHER-2026') _
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classic stuff...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line will be rolled back once the feature is completely tested.

folioHelm.withKubeConfig(namespace.clusterName) {
folioHelm.deployFolioModule(namespace, module.name, module.version, false, namespace.defaultTenantId)
echo "Module ${module.name}-${module.version} deployed to ${namespace.clusterName} namespace ${namespace.workspaceName}"
echo "Waiting another 3 minutes to get module initialized..."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use checkDeploymentrunning instead of sleeping...

eureka.enableApplicationsOnTenantsFlow(namespace.tenants, updatedAppInfoMap)
} catch (e) {
logger.warning("Failed to enable (entitle) new application version: ${e}")
eureka.removeResourcesOnFailFlow(updatedAppInfoMap, module)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will brake whole env...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eldiiar-duishenaliev
Could you please provide more details why you think so?

@Library('pipelines-shared-library@RANCHER-2026') _

import org.jenkinsci.plugins.workflow.libs.Library
import org.folio.Constants
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is and for what it will be used?(meaning whole file)

@@ -36,7 +36,7 @@ class Constants {
static String AWS_EKS_ADMIN_USERS = 'rancher-port-forward,oleksandrhaimanov,eldiiarduishenaliev,tarasspashchenko,stanislav,arsenatoyan,dmytromoroz,vasylavramenko,yaroslavishchenko,sergiimasiuk'
static List AWS_EKS_CLUSTERS = ['folio-testing', 'folio-dev', 'folio-perf', 'folio-tmp', 'folio-etesting', 'folio-edev']
//tmp excluded: 'folio-eperf', 'folio-etmp
static List AWS_EKS_TMP_NAMESPACES = ['test', 'test-1', 'test-2', 'tdspora']
static List AWS_EKS_TMP_NAMESPACES = ['yari', 'test', 'test-1', 'test-2', 'tdspora']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crazy stuff!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry :)
This change will be removed after testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants