update callback names for better readability

folio-org · Nov 3, 2023 · 1b6cb98 · 1b6cb98
1 parent b946cca
commit 1b6cb98
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 14 deletions.
diff --git a/lib/DonorsList/AddDonorButton.js b/lib/DonorsList/AddDonorButton.js
@@ -13,13 +13,13 @@ import {
   visibleFilters,
 } from './constants';
 
-const AddDonorButton = ({ fetchDonors, fields, stripes, name }) => {
+const AddDonorButton = ({ onAddDonors, fields, stripes, name }) => {
   const addDonors = (donors = []) => {
     const addedDonorIds = new Set(fields.value);
     const newDonorsIds = map(donors.filter(({ id }) => !addedDonorIds.has(id)), 'id');
 
     if (newDonorsIds.length) {
-      fetchDonors([...addedDonorIds, ...newDonorsIds]);
+      onAddDonors([...addedDonorIds, ...newDonorsIds]);
       newDonorsIds.forEach(contactId => fields.push(contactId));
     }
   };
@@ -51,7 +51,7 @@ const AddDonorButton = ({ fetchDonors, fields, stripes, name }) => {
 };
 
 AddDonorButton.propTypes = {
-  fetchDonors: PropTypes.func.isRequired,
+  onAddDonors: PropTypes.func.isRequired,
   fields: PropTypes.object,
   stripes: PropTypes.object,
   name: PropTypes.string.isRequired,

diff --git a/lib/DonorsList/DonorsContainer.js b/lib/DonorsList/DonorsContainer.js
@@ -1,4 +1,4 @@
-import React, { useCallback, useState } from 'react';
+import React, { useState } from 'react';
 import PropTypes from 'prop-types';
 import { FieldArray } from 'react-final-form-arrays';
 
@@ -15,10 +15,6 @@ function DonorsContainer({ name, donorOrganizationIds }) {
   const [donorIds, setDonorIds] = useState(() => donorOrganizationIds);
   const { donors, isLoading } = useFetchDonors(donorIds);
 
-  const handleFetchDonors = useCallback(ids => {
-    setDonorIds(ids);
-  }, []);
-
   const donorsMap = donors.reduce((acc, contact) => {
     acc[contact.id] = contact;
 
@@ -36,7 +32,7 @@ function DonorsContainer({ name, donorOrganizationIds }) {
           name={name}
           id={name}
           component={DonorsList}
-          fetchDonors={handleFetchDonors}
+          setDonorIds={setDonorIds}
           donorsMap={donorsMap}
         />
       </Col>

diff --git a/lib/DonorsList/DonorsList.js b/lib/DonorsList/DonorsList.js
@@ -50,7 +50,7 @@ const getResultsFormatter = ({
   ),
 });
 
-const DonorsList = ({ fetchDonors, fields, donorsMap, id }) => {
+const DonorsList = ({ setDonorIds, fields, donorsMap, id }) => {
   const intl = useIntl();
   const stripes = useStripes();
   const canViewOrganizations = stripes.hasPerm('ui-organizations.view');
@@ -82,7 +82,7 @@ const DonorsList = ({ fetchDonors, fields, donorsMap, id }) => {
       />
       <br />
       <AddDonorButton
-        fetchDonors={fetchDonors}
+        onAddDonors={setDonorIds}
         fields={fields}
         stripes={stripes}
         name={id}
@@ -92,7 +92,7 @@ const DonorsList = ({ fetchDonors, fields, donorsMap, id }) => {
 };
 
 DonorsList.propTypes = {
-  fetchDonors: PropTypes.func.isRequired,
+  setDonorIds: PropTypes.func.isRequired,
   fields: PropTypes.object,
   donorsMap: PropTypes.object,
   id: PropTypes.string.isRequired,

diff --git a/lib/DonorsList/DonorsList.test.js b/lib/DonorsList/DonorsList.test.js
@@ -3,10 +3,10 @@ import { render, screen } from '@testing-library/react';
 
 import DonorsList from './DonorsList';
 
-const mockFetchDonors = jest.fn();
+const mockSetDonorIds = jest.fn();
 
 const defaultProps = {
-  fetchDonors: mockFetchDonors,
+  setDonorIds: mockSetDonorIds,
   fields: {},
   donorsMap: {},
   id: 'donors',