Skip to content

Commit

Permalink
Allow nodes for ConfirmationModal heading (#2250)
Browse files Browse the repository at this point in the history
(cherry picked from commit 47d679e)
  • Loading branch information
ncovercash authored and zburke committed Mar 25, 2024
1 parent ed94ec5 commit 1901348
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/ConfirmationModal/ConfirmationModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const propTypes = {
cancelButtonStyle: PropTypes.string,
cancelLabel: PropTypes.node,
confirmLabel: PropTypes.node,
heading: PropTypes.string.isRequired,
heading: PropTypes.node.isRequired,
id: PropTypes.string,
isConfirmButtonDisabled: PropTypes.bool,
message: PropTypes.oneOfType([
Expand Down
2 changes: 1 addition & 1 deletion lib/ConfirmationModal/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ handleSubmit() {

Name | type | description | default | required
--- | --- | --- | --- | ---
heading | string | String to appear as the modal's H1 tag. Doubles as the modal's ARIA-label | | ✔
heading | node | String to appear as the modal's H1 tag | | ✔
message | node or array of nodes | Renderable content rendered within a `<p>` tag. | |
open | bool | Boolean reflecting modal's open/closed status | | &#10004;
cancelLabel | node | String to render on the Cancel action. | "Cancel" |
Expand Down

0 comments on commit 1901348

Please sign in to comment.