STCOM-1228 Print styling of panes (users want to print the detail pane, but full screen display is printed) #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
zburke
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM, but this isn't the first time we've faced problems. I'm OK moving ahead with this, but in an ideal world it would be good to have a better understanding of what has changed since STCOM-975 / #1835 such that we are seeing this problem now.
|
Previous PR's fixed different problems from this one - but this issue definitely seems like one that was resolved a long time ago :/ |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
…e, but full screen display is printed) (#2170) * apply print styles so that only last pane is visible at full width * log changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing with a detail pane open should print only the detail pane, without printing the others. The before state is captured in the associated JIRAs.
Approach
Adjusted the styles of panes to have only the last pane visible and at 100% width when the page is printed.
Used a combination of hiding panes in print mode, and displaying the last pane via a higher specificity pseudo-selector (
nth-last-of-type(1))The
flexproperty is!importantin this case in order to override the inlineflexstyling that is applied to the element.Two stories, https://issues.folio.org/browse/STCOM-1228 and https://issues.folio.org/browse/STCOM-1229 are covered by this...
After:
Inventory:
Users:
