STCOM-1192 Group checkboxes in FilterGroups (a11y) #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncovercash
reviewed
Feb 16, 2024
| @@ -314,7 +327,7 @@ FilterGroups.propTypes = { | |||
| config: PropTypes.arrayOf( | |||
| PropTypes.shape({ | |||
| cql: PropTypes.string.isRequired, | |||
| label: PropTypes.string.isRequired, | |||
| label: PropTypes.oneOfType([PropTypes.string, PropTypes.element]).isRequired, | |||
There was a problem hiding this comment.
made a stripes-types edit folio-org/stripes-types#55
ncovercash
approved these changes
Feb 16, 2024
…n id of FilterGroup
|
github-actions bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
* accept full label id from outside of the component via headerProps * allow for elements in label proptype. Derive string from within FormatMessage, if supplied. * Get string from possible FormattedMessage in group label for Accordion id of FilterGroup * log changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/STCOM-1192
Related inputs are commonly group within a
<fieldset>element or adivelement usingrole=group. Both do similar things, assigning a top-level label. The downside to fieldset is that it has a built-in styling that has to be overridden and<legend>elements can also be stubborn for styling, although that is less of a matter. Adiv[role="group"]with anaria-labelsuffices.<Filtergroups>often wouldn't be able to render a decent unique id due to objects (<FormattedMessage>) being passed as the label to the groups, despite propTypes dictating it be astring. A small utility function was used to derive the string from a passedFormatMessageinstance, converting it to a call toformatMessagefronIntlcontenxt.Proptypes of FilterGroups were expanded to relax common proptype errors in the console and we reduce the number of
id="[object Object]"occurrences in the DOM.From Snapshot Environment:
[object Object]id's... egad!Ah... no longer (after change)
