Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STCOM-1344 - Selection render value via formatter to contain text #2356

Merged
merged 7 commits into from
Oct 2, 2024
Merged

STCOM-1344 - Selection render value via formatter to contain text #2356

merged 7 commits into from
Oct 2, 2024

Conversation

JohnC-80
Copy link
Contributor

@JohnC-80 JohnC-80 commented Oct 1, 2024 •
edited
Loading

Resolves STCOM-1344

<Selection> previously rendered the raw string value within the control rather than rendering it through the item formatter and excluding the word-wrap: break-word CSS styling that would wrap longer values and keep them contained within the field.

Before:

image

After:

image

@JohnC-80 JohnC-80 requested a review from a team October 1, 2024 21:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

Bigtest Unit Test Results

    1 files  ±0      1 suites  ±0   14s ⏱️ ±0s
1 521 tests ±0  1 513 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 523 runs  ±0  1 515 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit c8cafcf. ± Comparison against base commit e5e1421.

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team October 2, 2024 06:26
zburke
zburke reviewed Oct 2, 2024
View reviewed changes
lib/Selection/Selection.js Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JohnC-80 JohnC-80 merged commit 4349f10 into master Oct 2, 2024
25 checks passed
@JohnC-80 JohnC-80 deleted the STCOM-1344 branch October 2, 2024 16:01
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@JohnC-80
STCOM-1344 - Selection render value via formatter to contain text (#2356
8fb7318 
)

* render value via formatter to contain text

* Update CHANGELOG.md

* trim empty searchTerm prop in value filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dmytro-Melnyshyn Dmytro-Melnyshyn Dmytro-Melnyshyn approved these changes

@zburke zburke zburke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnC-80 @zburke @Dmytro-Melnyshyn