Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STCOM-1332 Selection should occupy the full width of its container. #2385

Merged
merged 3 commits into from
Nov 8, 2024
Merged

STCOM-1332 Selection should occupy the full width of its container. #2385

merged 3 commits into from
Nov 8, 2024

Conversation

JohnC-80
Copy link
Contributor

@JohnC-80 JohnC-80 commented Nov 6, 2024 •
edited
Loading

STCOM-1332

Prior to refactor, the outer element for selection had an inline style that set the width to 100%

stripes-components/lib/Selection/SingleSelect.js

Lines 675 to 678 in 4b25bb9

<div
style={{ position: 'relative', width: '100%' }}
ref={this.container}
>

This change re-applies that style as a CSS class.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Bigtest Unit Test Results

    1 files  ±0      1 suites  ±0   15s ⏱️ ±0s
1 531 tests ±0  1 523 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 533 runs  ±0  1 525 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 65d584b. ± Comparison against base commit 651f68c.

♻️ This comment has been updated with latest results.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JohnC-80 JohnC-80 requested review from zburke and a team November 8, 2024 17:47
@JohnC-80 JohnC-80 merged commit 14df458 into master Nov 8, 2024
15 checks passed
@JohnC-80 JohnC-80 deleted the STCOM-1332 branch November 8, 2024 20:46
github-actions bot pushed a commit that referenced this pull request Nov 8, 2024
@JohnC-80
STCOM-1332 Selection should occupy the full width of its container. (#…
036bd39 
…2385)

* wrap Selection in full-width div

* log changes

* add position: relative to SelectionOuter CSS class
zburke pushed a commit that referenced this pull request Nov 8, 2024
@JohnC-80 @zburke
STCOM-1332 Selection should occupy the full width of its container. (#…
7cab7d8 
…2385)

* wrap Selection in full-width div

* log changes

* add position: relative to SelectionOuter CSS class

(cherry picked from commit 14df458)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zburke zburke zburke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnC-80 @zburke