STCOM-1382 Assign modal escape key handler to modal element rather than document #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zburke
approved these changes
Nov 13, 2024
|
Please update the commit subject with the JIRA slug when you merge. Release scripts use the commit subject, not the PR title, to find tickets in Jira and set the fixVersion field. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STCOM-1382
See UIQM-732 for the module-level bug.
Modal hangs its escape key listener on the
documentrather than one of its owned elements. this can be problematic if an app has aescapeshortcut key that's set up the same way. See the UI-QuickMarc bug for details. TLDR:escapekey in dirty form should trigger the confirmation modal, but instead it opens the modal and immediately closes it, exiting the form without any confirmation.