-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STCOM-1391 Tooltip - check for hover on tooltip content before closing the tooltip. #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnC-80
changed the title
Tooltip - check for hover on tooltip content before closing the tooltip.
STCOM-1391 Tooltip - check for hover on tooltip content before closing the tooltip.
Jan 2, 2025
Dmytro-Melnyshyn
approved these changes
Jan 6, 2025
mariia-aloshyna
approved these changes
Jan 6, 2025
zburke
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There is a reason I only every type a11y 😆
Quality Gate passedIssues Measures |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
…g the tooltip. (#2411) According to [WCAG](https://www.w3.org/TR/WCAG21/#content-on-hover-or-focus), content that's available/visible on hover should remain visible when the content itself is hovered... mouse-readers everywhere unite! ### Approach Tooltip already uses timeouts to provide a brief gap between event listeners and state updates. This implementation added a timeout to hiding the tooltip where we only hide the tooltip if neither the trigger nor the tooltip element itself are hovered by the mouse (using `matches(':hover')`). The CSS of the tooltip class had to be affected to observe mouse events since they are all placed in the `#OverlayContainer` by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to WCAG, content that's available/visible on hover should remain visible when the content itself is hovered... mouse-readers everywhere unite!
Approach
Tooltip already uses timeouts to provide a brief gap between event listeners and state updates. This implementation added a timeout to hiding the tooltip where we only hide the tooltip if neither the trigger nor the tooltip element itself are hovered by the mouse (using
matches(':hover')
). The CSS of the tooltip class had to be affected to observe mouse events since they are all placed in the#OverlayContainer
by default.