Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERM-3119 Add Organisation status to organisation card display #655

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

CalamityC
Copy link
Contributor

  • add org.orgsUuid_object.status to renderOrganizationName

Copy link

github-actions bot commented Dec 4, 2023

Jest Unit Test Statistics

    1 files  ±0    35 suites  ±0   3m 15s ⏱️ ±0s
247 tests ±0  247 ✔️ ±0  0 💤 ±0  0 ±0 
254 runs  ±0  254 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 1dfb83a. ± Comparison against base commit 7e95fab.

♻️ This comment has been updated with latest results.

@CalamityC CalamityC marked this pull request as ready for review December 4, 2023 17:10
* add orgStatus to newly added org in edit page
</KeyValue>
);
const renderOrganizationName = (name) => {
const orgStatus = org.orgsUuid_object?.status ? org.orgsUuid_object.status :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CalamityC For brevity, in future this can be written org.orgsUuid_object?.status ?? org?.status. Not going to block this merge for that though, it can be tweaked later if we want.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

73.3% 73.3% Coverage
0.0% 0.0% Duplication

@EthanFreestone EthanFreestone merged commit bff4bb6 into master Dec 11, 2023
4 checks passed
@EthanFreestone EthanFreestone deleted the erm-3119 branch December 11, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants