Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERM-3041 Dashboard: the "unsaved changes" confirmation modal is missing #663

Merged
merged 13 commits into from
Mar 12, 2024
Merged

ERM-3041 Dashboard: the "unsaved changes" confirmation modal is missing #663

merged 13 commits into from
Mar 12, 2024

Conversation

CalamityC
Copy link
Contributor

  • create useErmForm hook
  • add useHistory
  • move props from hook to ERMForm
  • keep navigationCheck prop in hook and default to true
  • pass string instead of object to ConfirmationModals heading
  • add translations

@CalamityC
ERM-3041 Dashboard: the "unsaved changes" confirmation modal is missing
a591da5 
* create first draft of useErmForm hook
@CalamityC
ERM-3041 Dashboard: the "unsaved changes" confirmation modal is missing
d30bee2 
* add useHistory
@CalamityC
Merge branch 'master' into erm-3041
dbe4bb2
@CalamityC
ERM-3041 Dashboard: the "unsaved changes" confirmation modal is missing
510f65e 
* move props from hook to ERMForm
* keep navigationCheck prop in hook and default to true
@CalamityC
ERM-3041 Dashboard: the "unsaved changes" confirmation modal is missing
23590ca 
* pass string instead of object to ConfirmationModals heading
@CalamityC
ERM-3041 Dashboard: the "unsaved changes" confirmation modal is missing
8492838 
* add translations
@CalamityC
* make FormComponent a node
d58a208
@CalamityC
Revert "* make FormComponent a node"
7bf93e7 
This reverts commit d58a208.
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0    35 suites  ±0   3m 28s ⏱️ +7s
247 tests ±0  247 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
254 runs  ±0  254 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ff751b6. ± Comparison against base commit 1287952.

♻️ This comment has been updated with latest results.

CalamityC and others added 5 commits February 13, 2024 15:57
@CalamityC
* remove empty ghost file
af3d0c4
@CalamityC
Merge branch 'master' into erm-3041
d200ec4
@CalamityC
ERM-3041
67d0eeb 
* try useCallback
@EthanFreestone
fix: WIP Swap to ref based checks
6b36b5a 
Currently not reading properly on useEffect cleanup, got to work out why formSpyRef isn't properly read in unblock cleanup function
@EthanFreestone
feat: ERM Form
ff751b6 
Split out ERM Form into a proper component, and leave the hook implementation as is. Cleans up implementation in our apps
@EthanFreestone EthanFreestone mentioned this pull request Mar 12, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@EthanFreestone EthanFreestone marked this pull request as ready for review March 12, 2024 13:58
@EthanFreestone EthanFreestone merged commit 5ca9f56 into master Mar 12, 2024
4 of 5 checks passed
@EthanFreestone EthanFreestone deleted the erm-3041 branch March 12, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CalamityC @EthanFreestone