ERM-3220 Update pagination mechanisms for MCLs to work without stats #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CalamityC
commented
Apr 30, 2024
•
CalamityC
commented
- create new hook for fetch with no stats
- add hasNextPage prop to usePrevNextPagination
* add pageCount property
* create new hook for fetch with no stats * add hasNextPage prop to usePrevNextPagination
* create new hook for fetch with no stats * add hasNextPage prop to usePrevNextPagination
Now the hasNextPage overwrites the canGoNext calculation if it is provided
* rename hook * set defaukt page
* remove comments * add resetPageStore function
* remove resetPageStore function
EthanFreestone
requested changes
May 16, 2024
There was a problem hiding this comment.
Overall code looks really good. Happy with the overall idea, just one small tweak requested to the queryKey logic in useFetchCurrentAndNext.
I think it's probably out of scope for this piece of work, but it'd be kinda neat to not limit useCurrentAndNext to just fetching 2 pages. Can it be renamed to something like "useFetchMultiplePages"? For now the logic can remain the same, but with a comment explaining that it's named like this to allow for future expansion to n pages down the line
Renamed hook to "useFetchMultiplePages", so it will be primed for any future logic to expand past just two pages. For now it will make use of the page passed in the params object Also changed out keyArray for getQueryKey which allows finer control over the queryKey for the implementing code refs ERM-3220
|
EthanFreestone
approved these changes
May 17, 2024
EthanFreestone
added a commit
that referenced
this pull request
May 28, 2024
…680) * ERM-3220 Update pagination mechanisms for MCLs to work without stats * add pageCount property * ERM-3220 Update pagination mechanisms for MCLs to work without stats * create new hook for fetch with no stats * add hasNextPage prop to usePrevNextPagination * ERM-3220 Update pagination mechanisms for MCLs to work without stats * create new hook for fetch with no stats * add hasNextPage prop to usePrevNextPagination * refactor: Changed hasNextPage functionality Now the hasNextPage overwrites the canGoNext calculation if it is provided * refactor: Spread params tidy up * ERM-3220 Update pagination mechanisms for MCLs to work without stats * rename hook * set defaukt page * ERM-3220 Update pagination mechanisms for MCLs to work without stats * remove comments * add resetPageStore function * ERM-3220 Update pagination mechanisms for MCLs to work without stats * remove resetPageStore function * feat: useFetchMultiplePages Renamed hook to "useFetchMultiplePages", so it will be primed for any future logic to expand past just two pages. For now it will make use of the page passed in the params object Also changed out keyArray for getQueryKey which allows finer control over the queryKey for the implementing code refs ERM-3220 --------- Co-authored-by: Jack Golding <[email protected]> Co-authored-by: Ethan Freestone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.