Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 9.1.2 #682

Merged
merged 3 commits into from
May 28, 2024
Merged

Release 9.1.2 #682

merged 3 commits into from
May 28, 2024

Conversation

EthanFreestone
Copy link
Contributor

No description provided.

folio-translations and others added 3 commits May 28, 2024 15:01
…680)

* ERM-3220 Update pagination mechanisms for MCLs to work without stats

* add pageCount property

* ERM-3220 Update pagination mechanisms for MCLs to work without stats

* create new hook for fetch with no stats
* add hasNextPage prop to usePrevNextPagination

* ERM-3220 Update pagination mechanisms for MCLs to work without stats

* create new hook for fetch with no stats
* add hasNextPage prop to usePrevNextPagination

* refactor: Changed hasNextPage functionality

Now the hasNextPage overwrites the canGoNext calculation if it is provided

* refactor: Spread params tidy up

* ERM-3220 Update pagination mechanisms for MCLs to work without stats

* rename hook
* set defaukt page

* ERM-3220 Update pagination mechanisms for MCLs to work without stats

* remove comments
* add resetPageStore function

* ERM-3220 Update pagination mechanisms for MCLs to work without stats

* remove resetPageStore function

* feat: useFetchMultiplePages

Renamed hook to "useFetchMultiplePages", so it will be primed for any future logic to expand past just two pages. For now it will make use of the page passed in the params object

Also changed out keyArray for getQueryKey which allows finer control over the queryKey for the implementing code

refs ERM-3220

---------

Co-authored-by: Jack Golding <[email protected]>
Co-authored-by: Ethan Freestone <[email protected]>
Added CHANGELOG section and bumped version -> 9.1.2

ERM-3242
Copy link

github-actions bot commented May 28, 2024

Jest Unit Test Statistics

    1 files  ±0    37 suites  ±0   2m 54s ⏱️ +3s
263 tests ±0  263 ✔️ ±0  0 💤 ±0  0 ±0 
270 runs  ±0  270 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 216eb0e. ± Comparison against base commit 49ad8d0.

♻️ This comment has been updated with latest results.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@EthanFreestone EthanFreestone merged commit 6883040 into release_9.1.x May 28, 2024
4 of 5 checks passed
@EthanFreestone EthanFreestone deleted the release_9.1.2 branch May 28, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants