ERM-3395, Complete absent test cases for stripes-erm-components document filter #709

MonireRasouli · 2024-11-07T20:35:14Z

No description provided.

github-actions · 2024-11-07T20:35:25Z

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

github-actions · 2024-11-07T20:37:42Z

Jest Unit Test Results

1 files ± 0 42 suites ±0 1m 20s ⏱️ +5s
339 tests +21 339 ✅ +21 0 💤 ±0 0 ❌ ±0
340 runs +21 340 ✅ +21 0 💤 ±0 0 ❌ ±0

Results for commit 92815e4. ± Comparison against base commit 241dc35.

This pull request removes 24 and adds 45 tests. Note that renamed tests count towards both.

DocumentFilterField Render DocumentFilterField with 0 in the array displays attibute label(s) ‑ DocumentFilterField Render DocumentFilterField with 0 in the array displays attibute label(s)
DocumentFilterField Render DocumentFilterField with 0 in the array displays operator label(s) ‑ DocumentFilterField Render DocumentFilterField with 0 in the array displays operator label(s)
DocumentFilterField Render DocumentFilterField with 0 in the array displays value label(s) ‑ DocumentFilterField Render DocumentFilterField with 0 in the array displays value label(s)
DocumentFilterField Render DocumentFilterField with 1 in the array displays attibute label(s) ‑ DocumentFilterField Render DocumentFilterField with 1 in the array displays attibute label(s)
DocumentFilterField Render DocumentFilterField with 1 in the array displays operator label(s) ‑ DocumentFilterField Render DocumentFilterField with 1 in the array displays operator label(s)
DocumentFilterField Render DocumentFilterField with 1 in the array displays value label(s) ‑ DocumentFilterField Render DocumentFilterField with 1 in the array displays value label(s)
DocumentFilterField Render DocumentFilterField with 1 in the array renders the add rule button ‑ DocumentFilterField Render DocumentFilterField with 1 in the array renders the add rule button
DocumentFilterField Render DocumentFilterField with 2 in the array displays attibute label(s) ‑ DocumentFilterField Render DocumentFilterField with 2 in the array displays attibute label(s)
DocumentFilterField Render DocumentFilterField with 2 in the array displays operator label(s) ‑ DocumentFilterField Render DocumentFilterField with 2 in the array displays operator label(s)
DocumentFilterField Render DocumentFilterField with 2 in the array displays value label(s) ‑ DocumentFilterField Render DocumentFilterField with 2 in the array displays value label(s)
…

DocumentFilter ActiveFilter tests with active filters should clear the selected document filters by clicking on the clear button ‑ DocumentFilter ActiveFilter tests with active filters should clear the selected document filters by clicking on the clear button
DocumentFilter ActiveFilter tests with multiple active filters should clear the selected document filters by clicking on the clear button ‑ DocumentFilter ActiveFilter tests with multiple active filters should clear the selected document filters by clicking on the clear button
DocumentFilter ActiveFilter tests without active filters should clear the selected document filters by clicking on the clear button ‑ DocumentFilter ActiveFilter tests without active filters should clear the selected document filters by clicking on the clear button
DocumentFilterField Render 0 DocumentFilterField component(s) DocumentFilterRule interactions does not render the add rule button ‑ DocumentFilterField Render 0 DocumentFilterField component(s) DocumentFilterRule interactions does not render the add rule button
DocumentFilterField Render 0 DocumentFilterField component(s) DocumentFilterRule interactions renders 0 DocumentFilterRule components ‑ DocumentFilterField Render 0 DocumentFilterField component(s) DocumentFilterRule interactions renders 0 DocumentFilterRule components
DocumentFilterField Render 0 DocumentFilterField component(s) displays attribute label(s) ‑ DocumentFilterField Render 0 DocumentFilterField component(s) displays attribute label(s)
DocumentFilterField Render 0 DocumentFilterField component(s) displays operator label(s) ‑ DocumentFilterField Render 0 DocumentFilterField component(s) displays operator label(s)
DocumentFilterField Render 0 DocumentFilterField component(s) displays value label(s) ‑ DocumentFilterField Render 0 DocumentFilterField component(s) displays value label(s)
DocumentFilterField Render 1 DocumentFilterField component(s) DocumentFilterRule interactions clicking add rule button a rule has been added ‑ DocumentFilterField Render 1 DocumentFilterField component(s) DocumentFilterRule interactions clicking add rule button a rule has been added
DocumentFilterField Render 1 DocumentFilterField component(s) DocumentFilterRule interactions renders 1 DocumentFilterRule component ‑ DocumentFilterField Render 1 DocumentFilterField component(s) DocumentFilterRule interactions renders 1 DocumentFilterRule component
…

♻️ This comment has been updated with latest results.

EthanFreestone · 2024-11-13T10:11:02Z

lib/DocumentFilter/DocumentFilter.test.js

@@ -139,7 +126,4 @@ describe('DocumentFilter', () => {
      });
    });
  });
-


This todo hasn't been done yet, so shouldn't be removed

EthanFreestone · 2024-11-13T10:15:13Z

lib/DocumentFilter/DocumentFilterField.test.js

-    if (expectedFields > 0) {
-      test('renders the add rule button', async () => {
-        await Button('Add rule').exists();
+      it('renders DocumentFilterRule component with the correct number of times by clicking the "Add rule" button', async () => {


This is a little overcomplicated. The big if/else isn't needed here. We can instead test:

Does the right number of DocumentFilterRule exist? (Use queryAllByText so the 0 case works)

Does add rule exist

Describe clicking add rule

Has number of DocumentFilterRules gone up by one?

In general the point of the .each at the top is so that this kind of case by case logic isn't needed inside the tests themselves. Let me know if you wan tme to walk through this case with you cos it's an interesting shift in test writing

EthanFreestone · 2024-11-13T10:16:50Z

lib/DocumentFilter/DocumentFilterFieldArray.test.js

    await Button('Add filter').exists();
+    await waitFor(async () => {


Please don't do this in a test.

Describe is for actions, test is for outcomes

lib/DocumentFilter/DocumentFilterFieldArray.test.js

EthanFreestone · 2024-11-13T10:21:57Z

lib/DocumentFilter/DocumentFilterRule.test.js

@@ -51,52 +54,65 @@ describe('DocumentFilterRule', () => {
    await Button('Submit').exists();
  });

-  it('renders Name option', () => {
+  test('renders the correct options for the Attribute dropdown', async () => {


I separated these deliberately... I want each test to be a single granular check. If this fails we don't know which field broke.

lib/DocumentFilter/DocumentFilterRule.test.js

EthanFreestone · 2024-11-13T10:22:42Z

lib/DocumentFilter/DocumentFilterRule.test.js

-  });
-
-  it('renders is option', () => {
+  test('renders the correct options for the Comparator dropdown', async () => {


Same thing as above though... pleasee keep individual checks in their own test/it

lib/DocumentFilter/DocumentFilterRule.test.js

Make use of new testSelect feature in stripes-erm-testing (Bump major version of stripes-erm-testing)

Tweaked test case for DocumentFilterRule to align with describe-action, test-outcome paradigm ERM-3395

sonarqubecloud · 2024-11-19T16:17:09Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

MonireRasouli added 2 commits November 5, 2024 15:01

extend DocumentFilter tests

6d44aa4

extend tests

e78e3d5

MonireRasouli added 2 commits November 9, 2024 18:28

extend tests for DocumentFilterFieldArray

293fd86

extend tests for DocumentFilterRule

fcf856c

MonireRasouli marked this pull request as ready for review November 12, 2024 16:39

EthanFreestone requested changes Nov 13, 2024

View reviewed changes

MonireRasouli added 3 commits November 13, 2024 10:23

tweak

bf2acfe

fix tests

70eeb96

fix tests for DocumentFilterFieldArray

fa69638

MonireRasouli requested a review from EthanFreestone November 19, 2024 09:23

EthanFreestone added 8 commits November 19, 2024 14:54

test: DocumentFilterField test tweaks

7a416f9

ci: Update centralised workflow to 1.6

bcf593a

test: DocumentFilterFieldArray test tweaks

ea68612

test: Monireh's changes (not pushed originally)

e33aadb

test: DocumentFilterForm test tweaks

2c608a9

test: stripes-erm-testing testSelect

ecf1a85

Make use of new testSelect feature in stripes-erm-testing (Bump major version of stripes-erm-testing)

test: DocumentFilterRule test

eedc47b

Tweaked test case for DocumentFilterRule to align with describe-action, test-outcome paradigm ERM-3395

chore: Javascript-ify some JSON

92815e4

EthanFreestone approved these changes Nov 19, 2024

View reviewed changes

EthanFreestone merged commit accf810 into master Nov 19, 2024
15 checks passed

EthanFreestone deleted the ERM-3395 branch November 19, 2024 16:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ERM-3395, Complete absent test cases for stripes-erm-components document filter #709

ERM-3395, Complete absent test cases for stripes-erm-components document filter #709

MonireRasouli commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024 •

edited

Loading

EthanFreestone Nov 13, 2024

EthanFreestone Nov 13, 2024

EthanFreestone Nov 13, 2024

EthanFreestone Nov 13, 2024

EthanFreestone Nov 13, 2024

EthanFreestone Nov 13, 2024

sonarqubecloud bot commented Nov 19, 2024

@@ @@ -139,7 +126,4 @@ describe('DocumentFilter', () => { @@
                     });
                   });
                 });

		await Button('Add filter').exists();
		await waitFor(async () => {

ERM-3395, Complete absent test cases for stripes-erm-components document filter #709

ERM-3395, Complete absent test cases for stripes-erm-components document filter #709

Conversation

MonireRasouli commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024 • edited Loading

Jest Unit Test Results

EthanFreestone Nov 13, 2024

Choose a reason for hiding this comment

EthanFreestone Nov 13, 2024

Choose a reason for hiding this comment

EthanFreestone Nov 13, 2024

Choose a reason for hiding this comment

EthanFreestone Nov 13, 2024

Choose a reason for hiding this comment

EthanFreestone Nov 13, 2024

Choose a reason for hiding this comment

EthanFreestone Nov 13, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 19, 2024

Quality Gate passed

github-actions bot commented Nov 7, 2024 •

edited

Loading