Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STSMACOM-842 A11y Bug - Date Range Filter does not announce its range validation. #1489

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

JohnC-80
Copy link
Contributor

@JohnC-80 JohnC-80 commented Jul 2, 2024

Currently , the <DateRangeFilter> does not announce a validation error. This PR renders the message within a div[role=alert] so that it will be announced through assistive tech.

@JohnC-80 JohnC-80 requested review from a team and vashjs July 2, 2024 15:18
Copy link

github-actions bot commented Jul 2, 2024

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit dec1ee5. ± Comparison against base commit 134d9ef.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 2, 2024

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   14s ⏱️ ±0s
496 tests ±0  459 ✔️ ±0  37 💤 ±0  0 ±0 
498 runs  ±0  461 ✔️ ±0  37 💤 ±0  0 ±0 

Results for commit dec1ee5. ± Comparison against base commit 134d9ef.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Aug 5, 2024

@JohnC-80 JohnC-80 merged commit d5c0f17 into master Aug 5, 2024
6 checks passed
@JohnC-80 JohnC-80 deleted the STSMACOM-842 branch August 5, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants