STSMACOM-848 Expose startLabel and endLabel props for DateRangeFilter #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-blazhko
approved these changes
Aug 13, 2024
Dmitriy-Litvinenko
approved these changes
Aug 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STSMACOM-848
Problem
<DateRangeFilter>fields are currently labeled as only as "From" and "To" by default... but for better context, they should be labeled more specifically to the context, for example the filters within Data Export have separate date range filters for "Started running" and "Ended running" - these should be labeled to include their "Started running", "Ended running" contexts so that AT users can easily disambiguate the fields.Approach
Expose
startLabelandendLabelprops for theDateRangeFilterso that specificaria-labels can be passed to the fields. For sighted users, the fields are already collected within their separate accordions.