STSMACOM-882 <NoteFields> improve "Display as pop-up" markup and fix label a11y issue.
#1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x label a11y issue.
Comment on lines
93
to
97
| <Label for="display-as-popup-group"> | ||
| <span className={styles.heading}> | ||
| <FormattedMessage id="stripes-smart-components.notes.displayAsPopup.label" /> | ||
| </span> | ||
| </Label> |
There was a problem hiding this comment.
I think the 2nd approach from the ticket is what we need, it will announce "grouping" and be an indicator for the association of checkboxes. This can be seen with NVDA, axe dev tools doesn't show it. The for attribute shouldn't work in React for label tags.
BogdanDenis
force-pushed
the
STSMACOM-882
branch
from
0638e4f to
d4c3c1a
Compare
Dmytro-Melnyshyn
approved these changes
Jan 7, 2025
mariia-aloshyna
approved these changes
Jan 7, 2025
|
zburke
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
axe previously showed an a11y issue related to checkbox group labels. Latest code doesn't show this issue anymore, but applied the fix anyways.
Re-organized "Display as pop-up" checkbox group markup.
Screenshots
Issues
STSMACOM-882