[UISACQCOMP-175] Add initial stripes-acq-components #42
Conversation
ncovercash
requested review from
zburke,
JohnC-80,
kjain110,
mweaver-ebsco and
a team
There was a problem hiding this comment.
@ncovercash, lint whines about "Unexpected any." in some files (AcqCheckboxFilter) but not others with the same declaration (AcqList/SingleSearchForm). Is that an inconsistency that should be fixed or do I just now know much about TS?
Most likely it's the latter, in which case this is fine. But I'd like to understand why a declaration that appears to be the same results in different behavior.
Not sure...my best guess is that we might be hitting some kind of limit in eslint, since there are so many of these in |
There was a problem hiding this comment.
Yay! 🎉 More lint complaints are now visible now that you handled all those 'no any' errors! 😒 Now we have lots of ... is defined but never used in files like acq-components/lib/constants/constants.d.ts. Same story as before: this complaint appears in some files but not in others that appear to have identical declarations.
Should we similarly ignore this complaint while developing these types?
|
Yep, this should be ignored too. It's not a top-level export which is why I think we're seeing the error (you'd have to do |
|
|
should be good now! |
Jira UISACQCOMP-175