Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STTYPES-15 Provide TS definitions for claiming feature in the stripes-acq-components lib #74

Merged
merged 6 commits into from
Dec 20, 2024
Merged

STTYPES-15 Provide TS definitions for claiming feature in the stripes-acq-components lib #74

merged 6 commits into from
Dec 20, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Dec 17, 2024 •
edited
Loading

Purpose

https://folio-org.atlassian.net/browse/STTYPES-15

Ref: folio-org/stripes-acq-components#841

Adding TypeScript typings for new claiming ACQ components:

  • <SendClaimActionMenuItem>
  • <SendClaimsModal>
  • <DelayClaimActionMenuItem>
  • <DelayClaimsModal>
  • <MarkUnreceivableActionMenuItem>
  • getClaimingIntervalFromDate
  • useClaimsDelay
  • useClaimsSend
  • usePiecesStatusBatchUpdate

Adding TypeScript typings for existing ACQ components:

  • useRecordsSelect
  • useShowCallout

Re-exporting react-final-form interfaces from stripes-final-form.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Jest Unit Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 3e91a83. ± Comparison against base commit 5b24b65.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam marked this pull request as ready for review December 18, 2024 08:46
@usavkov-epam usavkov-epam requested a review from a team as a code owner December 18, 2024 08:46
@usavkov-epam usavkov-epam requested a review from a team December 18, 2024 08:46
@usavkov-epam usavkov-epam mentioned this pull request Dec 18, 2024
Merged
11 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@usavkov-epam usavkov-epam merged commit 49a5ddc into master Dec 20, 2024
16 checks passed
@usavkov-epam usavkov-epam deleted the STTYPES-15 branch December 20, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azizjonnurov azizjonnurov azizjonnurov approved these changes

@JohnC-80 JohnC-80 JohnC-80 approved these changes

@ncovercash ncovercash Awaiting requested review from ncovercash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usavkov-epam @JohnC-80 @azizjonnurov