STTYPES-17 Provide TS definition for claiming feature in the stripes-acq-components lib #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zburke
reviewed
Jan 6, 2025
There was a problem hiding this comment.
The code change LGTM but the PR is missing many required details:
- Create a ticket in the correct, corresponding project (probably a new ticket in STTYPES that links to the existing ticket in UICLAIM)
- Provide a PR description. It's polite to link to the Jira in the body (yes, you specified a ticket in the PR title, but the PR title isn't a link)
- The PR title must accurately reflect the work (this PR does not contain any code to sort anything; it exports types)
azizjonnurov
changed the title
usavkov-epam
requested changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/STTYPES-17
Add TypeScript typing for new claiming GroupByOrgActionMenuItem component