Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRWEB-108 Favicons not injected into html template. #137

Merged
merged 2 commits into from
Mar 5, 2024
Merged

STRWEB-108 Favicons not injected into html template. #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70ec279
remove usage of speed measurer webpack plugin
JohnC-80 Mar 4, 2024
f4d6f73
log changes
JohnC-80 Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* Add postcss-plugin for relative color syntax support for Firefox. Refs STRWEB-103.
* Lock `favicons` to `7.1.4` due to build failures. Refs STRWEB-105.
* Update `typescript` from `^4.2.4` to `^5.3.3`. Refs STRWEB-104.
* Resolve issue with favicon referencing by removing `speed-measurer-webpack-plugin` and its wrapping of other webpack plugins. Refs STRWEB-108.

## [5.0.0](https://github.com/folio-org/stripes-webpack/tree/v5.0.0) (2023-10-11)
[Full Changelog](https://github.com/folio-org/stripes-webpack/compare/v4.2.0...v5.0.0)
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
"semver": "^7.1.3",
"serialize-javascript": "^5.0.0",
"source-map-loader": "^4.0.0",
"speed-measure-webpack-plugin": "^1.5.0",
"stream-browserify": "^3.0.0",
"style-loader": "^3.3.0",
"tapable": "^1.0.0",
Expand Down
7 changes: 2 additions & 5 deletions webpack.config.cli.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
const webpack = require('webpack');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const { EsbuildPlugin } = require('esbuild-loader');
const SpeedMeasurePlugin = require('speed-measure-webpack-plugin');
const buildBaseConfig = require('./webpack.config.base');

const cli = require('./webpack.config.cli');
Expand All @@ -27,7 +26,6 @@ const buildConfig = (stripesConfig) => {

const transpiledModules = getTranspiledModules(allModulePaths);
const transpiledModulesRegex = new RegExp(transpiledModules.join('|'));
const smp = new SpeedMeasurePlugin();

prodConfig.plugins = prodConfig.plugins.concat([
new webpack.ProvidePlugin({
Expand Down Expand Up @@ -61,12 +59,11 @@ const buildConfig = (stripesConfig) => {

prodConfig.module.rules.push(esbuildLoaderRule(allModulePaths));

const webpackConfig = smp.wrap({ plugins: prodConfig.plugins });
webpackConfig.plugins.push(
prodConfig.plugins.push(
new MiniCssExtractPlugin({ filename: 'style.[contenthash].css' })
);

return { ...prodConfig, ...webpackConfig };
return prodConfig;
};

module.exports = buildConfig;
Loading