Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge eval form into eval criteria #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Merge eval form into eval criteria #86

wants to merge 2 commits into from

Conversation

julianladisch
Copy link
Contributor

  • Avoid two documents with almost the same content.
  • Avoid that the two documents get out of sync.
  • Ensure that the references to the "Values", like (6), are in the evaluation form, and can be found in both raw and rendered form.

@julianladisch
Merge eval template into eval criteria
6ed1686 
* Avoid two documents with almost the same content.
* Avoid that the two documents get out of sync.
* Ensure that the references to the "Values", like `(6)`, are in the evaluation form, and can be found in both raw and rendered form.
@julianladisch julianladisch requested a review from a team as a code owner December 9, 2024 13:15
maccabeelevine
maccabeelevine requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@maccabeelevine maccabeelevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion below, otherwise looks good

MODULE_ACCEPTANCE_CRITERIA.MD Show resolved Hide resolved
todolson
todolson approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@todolson todolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that this is a significant improvement. I don't have a strong view about the numbering under Values. Numbers make it easier to reference, but I take the point about renumbering. That said, I don't think this lists changes frequently.

kaladay
kaladay requested changes Dec 16, 2024
View reviewed changes
MODULE_ACCEPTANCE_CRITERIA.MD Outdated Show resolved Hide resolved
@julianladisch julianladisch requested review from kaladay and a team December 16, 2024 16:21
@maccabeelevine maccabeelevine mentioned this pull request Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladay kaladay kaladay approved these changes

@maccabeelevine maccabeelevine maccabeelevine approved these changes

@inkuss inkuss inkuss approved these changes

@todolson todolson todolson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@julianladisch @todolson @inkuss @maccabeelevine @kaladay