Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERM-3277 Add Material Type filter (Print/Electronic) to Title search #1344

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

CalamityC
Copy link
Contributor

  • add subType filter
  • name it material type

* add subType filter
* name it material type
Copy link

github-actions bot commented Aug 5, 2024

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

Copy link

github-actions bot commented Aug 5, 2024

Jest Unit Test Results

    1 files  ±0    154 suites  ±0   3m 52s ⏱️ -2s
1 026 tests +2  1 026 ✅ +2  0 💤 ±0  0 ❌ ±0 
1 033 runs  +2  1 033 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 9a5692d. ± Comparison against base commit 5f3e1a7.

♻️ This comment has been updated with latest results.

@CalamityC CalamityC marked this pull request as ready for review August 5, 2024 12:31
@CalamityC CalamityC requested a review from a team as a code owner August 5, 2024 12:31
Copy link
Contributor

@EthanFreestone EthanFreestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CalamityC, changes look great, but I'd rather the code reflect the names as per in the backend, so could materialType be changed for subType, with just the translation differing?

This is a matter of taste, it makes grepping slightly more difficult if a frontend facing user reports an issue, but makes it clearer I think to newer developers where the values come from etc. I'd rather keep the amount of alternative names developers have to understand "materialType == subType" etc to a minimum :)

Copy link

sonarqubecloud bot commented Aug 8, 2024

@EthanFreestone EthanFreestone merged commit 21bc8e0 into master Aug 16, 2024
15 checks passed
@EthanFreestone EthanFreestone deleted the erm-3277 branch August 16, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants