Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERM-3390 Show columns: Name column should not be in the list of unsel… #1366

Merged
merged 10 commits into from
Nov 11, 2024
Merged

ERM-3390 Show columns: Name column should not be in the list of unsel… #1366

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2eaa83d
ERM-3390 Show columns: Name column should not be in the list of unsel…
CalamityC Nov 4, 2024
70f4808
ERM-3390 Show columns: Name column should not be in the list of unsel…
CalamityC Nov 4, 2024
9e3ae72
Merge branch 'master' into erm-3390
EthanFreestone Nov 6, 2024
a262cec
fix test
CalamityC Nov 6, 2024
f637ef0
fix more tests
CalamityC Nov 6, 2024
f362050
test: Minor test tweaks (not really relevant)
EthanFreestone Nov 11, 2024
f7f2f83
test: Added route testing useEffect redirect (WIP... can be improved)
EthanFreestone Nov 11, 2024
060846e
test: Commented out now useless tests
EthanFreestone Nov 11, 2024
f7bd8e8
test: Fixed manual mock usage
EthanFreestone Nov 11, 2024
ebbe93a
test: Add mock for useEresourcesEnabled
EthanFreestone Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/AgreementSections/Lines/Lines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ const Lines = ({
</Button>
<ColumnManagerMenu
columnMapping={LINE_LISTING_COLUMN_MAPPING}
excludeColumns={['name']}
prefix="line-listing"
toggleColumn={toggleColumn}
visibleColumns={visibleColumns}
Expand Down
1 change: 1 addition & 0 deletions src/components/views/AgreementLines/AgreementLines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ const AgreementLines = ({
return (
<ColumnManagerMenu
columnMapping={AGREEMENT_LINES_COLUMN_MAPPING}
excludeColumns={['name']}
prefix="agreement-lines"
toggleColumn={toggleColumn}
visibleColumns={visibleColumns}
Expand Down
1 change: 1 addition & 0 deletions src/components/views/Agreements/Agreements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ const Agreements = ({
</IfPermission>
<ColumnManagerMenu
columnMapping={AGREEMENTS_COLUMN_MAPPING}
excludeColumns={['name']}
prefix="agreements-list"
toggleColumn={toggleColumn}
visibleColumns={visibleColumns}
Expand Down
Loading