ERM-3392 Changes to the field content type are not saved, but a success message is displayed #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CalamityC
commented
Nov 11, 2024
•
CalamityC
commented
- change agreementContentTypes initialValues on submit
…ss message is displayed * change agreementContentTypes initialValues on submit
|
License CLA Stuck? (Developer should make sure that it is really stuck before clicking) |
EthanFreestone
changed the title
EthanFreestone
requested changes
Nov 11, 2024
* fix field name, add parse and format
… of field level stuff In general, Claudia's solution is "nicer" in that it prevents ANY incorrect information from appearing in the PUT. However, it ends up doing a bunch of extra work inside the Select which we would then need to replicate everywhere to get the "best" solution consistently. We could (and an argument exists should) do this in a RefdataSelect type component, but then that would require special testing etc etc, and to be used in a very specific way. The easier fix (which is already used in some other places) is simply to use the id _only_. This makes some of the "only display refdata in use" logic a bit more complex, so we maybe ought to improve that and centralise it as well. ERM-3392
|
Jack-Golding
pushed a commit
that referenced
this pull request
Nov 29, 2024
…ss message is displayed (#1368) * ERM-3392 Changes to the field content type are not saved, but a success message is displayed * change agreementContentTypes initialValues on submit * * revert submit handler changes * fix field name, add parse and format * fix button * chore: Change over to just "id" in select to avoid having to do loads of field level stuff In general, Claudia's solution is "nicer" in that it prevents ANY incorrect information from appearing in the PUT. However, it ends up doing a bunch of extra work inside the Select which we would then need to replicate everywhere to get the "best" solution consistently. We could (and an argument exists should) do this in a RefdataSelect type component, but then that would require special testing etc etc, and to be used in a very specific way. The easier fix (which is already used in some other places) is simply to use the id _only_. This makes some of the "only display refdata in use" logic a bit more complex, so we maybe ought to improve that and centralise it as well. ERM-3392 --------- Co-authored-by: EthanFreestone <[email protected]> Co-authored-by: Ethan Freestone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.