Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UID-159] Better handle RTR callback; handle new token expiration format #438

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ncovercash
Copy link
Member

No description provided.

@ncovercash ncovercash requested a review from zburke October 10, 2024 20:20
Comment on lines -15 to -25
// why WHY copy this string here instead of importing it from stripes-core?
//
// RTR_FORCE_REFRESH_EVENT will be present in stripes-core 10.2.0 (stripes
// 9.2.0). Importing it would force the stripes peer depedency to bump from
// ^9.1.0 to ^9.2.0.If we copy the string instead of importing it, we can
// remain compatible with 9.1.0.
//
// OK, compatibility is nice. But it's still gross, right? Yep, super gross.
// Aren't you nauseated? Yes, yes I am. 🤢🧼🛁
const RTR_FORCE_REFRESH_EVENT = '@folio/stripes/core::RTRForceRefresh';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that ui-developer 9.0.0 is out, we should be safe to do 9.2.0 for R release.

Comment on lines +22 to +23
atExpires: te.atExpires ?? te.accessTokenExpiration ?? -1,
rtExpires: te.rtExpires ?? te.refreshTokenExpiration ?? -1,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safely handles old and new style

@ncovercash ncovercash requested a review from bvsharp October 10, 2024 20:23
@@ -88,7 +85,7 @@ const RefreshTokenRotation = ({ stripes }) => {
<FormattedMessage id="ui-developer.rtr.forceRefresh" />
</Button>

<Form
{/* <Form
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this form currently doesn't configure anything, due to that being pulled from STCOR-888, so let's hide it.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants