Skip to content

Commit

Permalink
UIEUS-307: empty values for selectboxes (#389)
Browse files Browse the repository at this point in the history
* UIEUS-307-empty-values-for-selectboxes

* UIEUS-307-empty-values-for-selectboxes change to null

* UIEUS-307-empty-values-for-selectboxes increase interface version

* Move empty entry to extractHarvesterImpls function
Set undefined on empty strings in onChange functions
Change null values to undefined

Co-authored-by: elsenhans <[email protected]>
Co-authored-by: alb3rtino <[email protected]>
  • Loading branch information
3 people authored Oct 17, 2022
1 parent cef9dd4 commit 20eb315
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
"counter-reports": "3.0",
"custom-reports": "1.0",
"erm-usage/files": "1.0",
"usage-data-providers": "2.7",
"usage-data-providers": "2.8",
"tags": "1.0"
},
"permissionSets": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class HarvestingConfigurationForm extends React.Component {
changeSelectedCounterVersion = (event) => {
event.preventDefault();

const val = parseInt(event.target.value, 10);
const val = (event.target.value === '') ? undefined : parseInt(event.target.value, 10);
const selectedReportRelease = get(
this.props.values,
'harvestingConfig.reportRelease',
Expand All @@ -61,7 +61,7 @@ class HarvestingConfigurationForm extends React.Component {
changeSelectedHarvestVia = (event) => {
event.preventDefault();

this.props.form.change(event.target.name, event.target.value);
this.props.form.change(event.target.name, (event.target.value === '') ? undefined : event.target.value);
this.props.form.resetFieldState('sushiCredentials.customerId');
};

Expand Down
1 change: 1 addition & 0 deletions src/util/data/harvestingViaOptions.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
export default [
{ value: undefined, label: '' },
{ value: 'aggregator', label: 'Aggregator' },
{ value: 'sushi', label: 'Sushi' }
];
1 change: 1 addition & 0 deletions src/util/data/reportReleaseOptions.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
export default [
{ value: undefined, label: '' },
{ value: 4, label: 'Counter 4' },
{ value: 5, label: 'Counter 5' },
];
6 changes: 4 additions & 2 deletions src/util/harvesterImpls.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
const extractHarvesterImpls = (resources) => {
const records = (resources.harvesterImpls || {}).records || [];
const records = resources.harvesterImpls?.records || [];
const implementations = records.length
? records[0].implementations
: [];
return implementations.map(i => ({
const results = implementations.map(i => ({
value: i.type,
label: i.name
}));
results.unshift({ value: undefined, label: '' });
return results;
};

export default extractHarvesterImpls;

0 comments on commit 20eb315

Please sign in to comment.