Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/master' into UIIN-2486
Browse files Browse the repository at this point in the history
  • Loading branch information
BogdanDenis committed Oct 30, 2023
2 parents d4b63e5 + 9460752 commit f86031a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

## [10.1.0] IN PROGRESS

* Make Inventory search and browse query boxes expandable. Refs UIIN-2493.
* Added support for `containsAny` match option in Advanced search. Refs UIIN-2486.

## [10.0.1] IN PROGRESS
Expand Down
1 change: 1 addition & 0 deletions src/components/InstancesList/InstancesList.js
Original file line number Diff line number Diff line change
Expand Up @@ -1178,6 +1178,7 @@ class InstancesList extends React.Component {
searchableIndexesPlaceholder={null}
initialResultCount={INITIAL_RESULT_COUNT}
initiallySelectedRecord={getItem(`${namespace}.${segment}.lastOpenRecord`)}
inputType="textarea"
resultCountIncrement={RESULT_COUNT_INCREMENT}
viewRecordComponent={ViewInstanceWrapper}
editRecordComponent={InstanceForm}
Expand Down
6 changes: 3 additions & 3 deletions src/components/InstancesList/InstancesList.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -458,10 +458,10 @@ describe('InstancesList', () => {
it('should have query in search input', () => {
renderInstancesList({ segment: 'instances' });

fireEvent.change(screen.getByRole('searchbox', { name: 'Search' }), { target: { value: 'search query' } });
fireEvent.change(screen.getByRole('textbox', { name: 'Search' }), { target: { value: 'search query' } });
fireEvent.click(screen.getAllByRole('button', { name: 'Search' })[1]);

expect(screen.getByRole('searchbox', { name: 'Search' })).toHaveValue('search query');
expect(screen.getByRole('textbox', { name: 'Search' })).toHaveValue('search query');
});

describe('when the search option is changed', () => {
Expand Down Expand Up @@ -549,7 +549,7 @@ describe('InstancesList', () => {

await act(async () => fireEvent.change(screen.getByLabelText('Search field index'), { target: { value: qindex } }));

fireEvent.change(screen.getByRole('searchbox', { name: 'Search' }), { target: { value: _query } });
fireEvent.change(screen.getByRole('textbox', { name: 'Search' }), { target: { value: _query } });
fireEvent.click(screen.getAllByRole('button', { name: 'Search' })[1]);

const row = screen.getAllByText('ABA Journal')[0];
Expand Down
1 change: 1 addition & 0 deletions src/views/BrowseInventory/BrowseInventory.js
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ const BrowseInventory = () => {
changeSearchIndex={onChangeSearchIndex}
selectedIndex={searchIndex}
searchableIndexesPlaceholder={searchableIndexesPlaceholder}
inputType="textarea"
/>

<ResetButton
Expand Down
2 changes: 1 addition & 1 deletion src/views/BrowseInventory/BrowseInventory.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ describe('BrowseInventory', () => {
it('should call "changeSearch" when search query was changed', async () => {
const { container } = renderBrowseInventory();

await act(async () => userEvent.type(screen.getByRole('searchbox'), 'newQuery'));
await act(async () => userEvent.type(screen.getByRole('textbox'), 'newQuery'));
await act(async () => userEvent.click(container.querySelector('[data-test-single-search-form-submit="true"]')));

expect(applySearch).toHaveBeenCalled();
Expand Down

0 comments on commit f86031a

Please sign in to comment.