UIIN-2453:Instance 3rd pane: Adjust behavior when returning to instance from holdings/item full screen #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce from holdings/item full screen
mariia-aloshyna
force-pushed
the
UIIN-2453
branch
from
f96b7e4 to
48c57d2
Compare
mariia-aloshyna
requested review from
BogdanDenis,
Dmytro-Melnyshyn and
a team
|
Kudos, SonarCloud Quality Gate passed! |
OleksandrHladchenko1
approved these changes
Oct 17, 2023
BogdanDenis
reviewed
Oct 17, 2023
| @@ -900,6 +900,7 @@ class ViewInstance extends React.Component { | |||
| }, | |||
| ]; | |||
| const isInstanceLoading = this.state.isLoading || !instance || isCentralTenantPermissionsLoading; | |||
| const keyInStorageToHoldingsAccsState = ['holdings']; | |||
There was a problem hiding this comment.
It looks like it could be a constant which can be imported and used directly in <HoldingAccordion> without passing it through the component tree. Is there any reason to have it passed as a prop?
There was a problem hiding this comment.
There is a reason, actually, because <HoldingsAccordion> is also used to render holdings for different member tenants under the Consortial holdings accordion, and it has a different path in storage.
So the structure is next:
{
holdings: {}, //local holdings of a current tenant
consortialHoldings: { memberTenant: {} }, //holdings of member tenants
}
BogdanDenis
approved these changes
Oct 17, 2023
mariia-aloshyna
added a commit
that referenced
this pull request
Nov 3, 2023
* UIIN-2453: Instance 3rd pane: Adjust behaviour when returning to instance from holdings/item full screen (#2305) (cherry picked from commit b7c19d1) * UIIN-2629: Consortial holdings accordion is not appearing after the sharing of Instance (#2312) (cherry picked from commit e03476f) * UIIN-2531 Reset CheckboxFacet state.more when user resets search form and fewer facet options are loaded. (#2310) (cherry picked from commit 749fead) * UIIN-2588: Edit instance success toast no longer shows the instance HRID (#2313) (cherry picked from commit dc738d2) * UIIN-2533: Show facet options, if they exist, after clicking the +More button. (#2309) (cherry picked from commit 1b6dca3) * UIIN-2608: If Shared & Held by facets were selected in the Browse search, then retain them in the Search lookup after clicking the record. (#2307) (cherry picked from commit 79771fb) * UIIN-2600: Remove error message after switch from Instance Edit screen to another app (#2311) (cherry picked from commit 3411d72) * Release v10.0.1 --------- Co-authored-by: Denys Bohdan <[email protected]> Co-authored-by: Dmytro-Melnyshyn <[email protected]> Co-authored-by: Oleksandr Hladchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In a consortium environment, Instance records may contain holdings from multiple institutions and users from one library may need to evaluate materials that are held by different institutions. Users affiliated with various member libraries should be able to view, create, and edit holdings for other member libraries, depending on their permissions for that affiliation, and then return to the Instance view that they started from.
Approach
sessionStorageto store state of holdings accordions for a particular instance so a user could get back to the view he started from when navigated away from instance details viewsessionStorageRefs
https://issues.folio.org/browse/UIIN-2453
Screenshots
uiin-2453.mov