UIIN-2608: If Shared & Held by facets were selected in the Browse search, then retain them in the Search lookup after clicking the record. #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch, then retain them in the Search lookup after clicking the record.
Dmytro-Melnyshyn
requested review from
BogdanDenis,
mariia-aloshyna,
OleksandrHladchenko1 and
a team
| }, | ||
| }); | ||
|
|
||
| await act(async () => fireEvent.click(screen.getByText(defaultProps.browseData[2].fullCallNumber))); |
There was a problem hiding this comment.
fireEvent is already wrapped in act as far as I know, do you wrap it because of asynchronous action?
There was a problem hiding this comment.
Also worth noting, userEvent > fireEvent most of the time when you want to do something like "click a button". You don't need to rewrite anything here, but consider it the next time you're writing new tests.
There was a problem hiding this comment.
@mariia-aloshyna I removed the act wrapper.
BogdanDenis
approved these changes
Oct 17, 2023
|
Hi @Dmytro-Melnyshyn Not all the eslint warnings are fixed it looks like |
|
Kudos, SonarCloud Quality Gate passed! |
mariia-aloshyna
added a commit
that referenced
this pull request
Nov 3, 2023
* UIIN-2453: Instance 3rd pane: Adjust behaviour when returning to instance from holdings/item full screen (#2305) (cherry picked from commit b7c19d1) * UIIN-2629: Consortial holdings accordion is not appearing after the sharing of Instance (#2312) (cherry picked from commit e03476f) * UIIN-2531 Reset CheckboxFacet state.more when user resets search form and fewer facet options are loaded. (#2310) (cherry picked from commit 749fead) * UIIN-2588: Edit instance success toast no longer shows the instance HRID (#2313) (cherry picked from commit dc738d2) * UIIN-2533: Show facet options, if they exist, after clicking the +More button. (#2309) (cherry picked from commit 1b6dca3) * UIIN-2608: If Shared & Held by facets were selected in the Browse search, then retain them in the Search lookup after clicking the record. (#2307) (cherry picked from commit 79771fb) * UIIN-2600: Remove error message after switch from Instance Edit screen to another app (#2311) (cherry picked from commit 3411d72) * Release v10.0.1 --------- Co-authored-by: Denys Bohdan <[email protected]> Co-authored-by: Dmytro-Melnyshyn <[email protected]> Co-authored-by: Oleksandr Hladchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If Shared & Held by facets were selected in the Browse search, then retain them in the Search lookup after clicking the record.
Approach
Refs
UIIN-2608
Screenshots
2023-10-13_16h47_47.mp4