UIIN-2533: Show facet options, if they exist, after clicking the +More button. #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmytro-Melnyshyn
requested review from
BogdanDenis,
mariia-aloshyna and
a team
zburke
approved these changes
Oct 17, 2023
CHANGELOG.md
Outdated
Comment on lines
3
to
5
| ## [10.0.1](IN PROGRESS) | ||
| * Show facet options, if they exist, after clicking the +More button. Refs UIIN-2533. | ||
|
|
There was a problem hiding this comment.
Generally, our practice is to target all changes to the master branch and then to cherry-pick fixes onto patch branches. If somebody else's PR hits master before yours lands, you'll have to do this anyway, so I just plan for things to work out this way. I would do it like this:
- Bump the version on master in
package.jsonto 10.1.0. You'll save a PR later if you do it in a separate PR now, but it's up to you. Either way it's two PRs in the end, so 🤷 . - Merge this PR.
- Split a release branch named
b10.0from the commit where master was tagged and push it up so others can also pick bug fixes onto : (get checkout master; git checkout -b b10.0 v10.0.0; git push -u origin head). - If you bumped the version in step 1 in a separate PR, you can just pick the commit from this PR onto your release branch:
git cherry-pick -x SOME_HASH; git push, you're done! If you bumped the version in step 1 in this PR, you'll need to split a branch fromb10.0, pick this fix onto it, fix the version inpackage.json, push the branch and open a PR with a target ofb10.0.
BogdanDenis
approved these changes
Oct 17, 2023
|
Kudos, SonarCloud Quality Gate passed! |
mariia-aloshyna
added a commit
that referenced
this pull request
Nov 3, 2023
* UIIN-2453: Instance 3rd pane: Adjust behaviour when returning to instance from holdings/item full screen (#2305) (cherry picked from commit b7c19d1) * UIIN-2629: Consortial holdings accordion is not appearing after the sharing of Instance (#2312) (cherry picked from commit e03476f) * UIIN-2531 Reset CheckboxFacet state.more when user resets search form and fewer facet options are loaded. (#2310) (cherry picked from commit 749fead) * UIIN-2588: Edit instance success toast no longer shows the instance HRID (#2313) (cherry picked from commit dc738d2) * UIIN-2533: Show facet options, if they exist, after clicking the +More button. (#2309) (cherry picked from commit 1b6dca3) * UIIN-2608: If Shared & Held by facets were selected in the Browse search, then retain them in the Search lookup after clicking the record. (#2307) (cherry picked from commit 79771fb) * UIIN-2600: Remove error message after switch from Instance Edit screen to another app (#2311) (cherry picked from commit 3411d72) * Release v10.0.1 --------- Co-authored-by: Denys Bohdan <[email protected]> Co-authored-by: Dmytro-Melnyshyn <[email protected]> Co-authored-by: Oleksandr Hladchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Show facet options, if they exist, after clicking the
+Morebutton.Approach
BE currently returns 6 options for the facet, but some of them may have already been removed. There is no way to fix it on the BE side. The UI was now looking at these 6 options in the data and displaying a
+Morebutton if all 6 options existed. Because there are only 5 options, the+Morebutton doesn't appear in the UI.After this PR, if the BE returns 6 options for the facet and some of them cannot be found in the data (deleted), we display the
+Morebutton, just do not render the deleted options, which we mark asisDeleted.Added
isFilterable,onSearch,onFetchprops to be able to filter options via the facet's input field.Refs
UIIN-2533
Screenshots
2023-10-17_13h15_00.mp4