Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2600: Remove error message after switch from Instance Edit screen to another app #2311

Merged
merged 7 commits into from
Oct 19, 2023

Conversation

OleksandrHladchenko1
Copy link
Contributor

Purpose

  • Remove error message "Something went wrong" after switch from Instance Edit screen to another app

Approach

  • Added optional chaining for instance form values

Refs

UIIN-2600

Screenshots

UIIN-2600.mp4

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Jest Unit Test Statistics

    1 files  ±0  226 suites  ±0   10m 32s ⏱️ - 5m 44s
880 tests ±0  878 ✔️ ±0  2 💤 ±0  0 ±0 
885 runs  ±0  883 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 65dc00a. ± Comparison against base commit 80749c3.

♻️ This comment has been updated with latest results.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We went from not enough null-checking to too much. Let's pick either ternary or optional chaining. It doesn't matter which but we don't need both.

src/edit/InstanceForm.js Outdated Show resolved Hide resolved
src/edit/InstanceForm.js Outdated Show resolved Hide resolved
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.7% 86.7% Coverage
0.0% 0.0% Duplication

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 3411d72 into master Oct 19, 2023
4 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIIN-2600 branch October 19, 2023 13:38
mariia-aloshyna pushed a commit that referenced this pull request Nov 3, 2023
…n to another app (#2311)

* UIIN-2600: Remove error message after switch from Instance Edit screen to another app

* UIIN-2600: Use ternary

* Update CHANGELOG.md

(cherry picked from commit 3411d72)
mariia-aloshyna added a commit that referenced this pull request Nov 3, 2023
* UIIN-2453: Instance 3rd pane: Adjust behaviour when returning to instance from holdings/item full screen (#2305)

(cherry picked from commit b7c19d1)

* UIIN-2629: Consortial holdings accordion is not appearing after the sharing of Instance (#2312)

(cherry picked from commit e03476f)

* UIIN-2531 Reset CheckboxFacet state.more when user resets search form and fewer facet options are loaded. (#2310)

(cherry picked from commit 749fead)

* UIIN-2588: Edit instance success toast no longer shows the instance HRID (#2313)

(cherry picked from commit dc738d2)

* UIIN-2533: Show facet options, if they exist, after clicking the +More button. (#2309)

(cherry picked from commit 1b6dca3)

* UIIN-2608: If Shared & Held by facets were selected in the Browse search, then retain them in the Search lookup after clicking the record. (#2307)

(cherry picked from commit 79771fb)

* UIIN-2600: Remove error message after switch from Instance Edit screen to another app (#2311)

(cherry picked from commit 3411d72)

* Release v10.0.1

---------

Co-authored-by: Denys Bohdan <[email protected]>
Co-authored-by: Dmytro-Melnyshyn <[email protected]>
Co-authored-by: Oleksandr Hladchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants