-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIIN-2600: Remove error message after switch from Instance Edit screen to another app #2311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We went from not enough null-checking to too much. Let's pick either ternary or optional chaining. It doesn't matter which but we don't need both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
* UIIN-2453: Instance 3rd pane: Adjust behaviour when returning to instance from holdings/item full screen (#2305) (cherry picked from commit b7c19d1) * UIIN-2629: Consortial holdings accordion is not appearing after the sharing of Instance (#2312) (cherry picked from commit e03476f) * UIIN-2531 Reset CheckboxFacet state.more when user resets search form and fewer facet options are loaded. (#2310) (cherry picked from commit 749fead) * UIIN-2588: Edit instance success toast no longer shows the instance HRID (#2313) (cherry picked from commit dc738d2) * UIIN-2533: Show facet options, if they exist, after clicking the +More button. (#2309) (cherry picked from commit 1b6dca3) * UIIN-2608: If Shared & Held by facets were selected in the Browse search, then retain them in the Search lookup after clicking the record. (#2307) (cherry picked from commit 79771fb) * UIIN-2600: Remove error message after switch from Instance Edit screen to another app (#2311) (cherry picked from commit 3411d72) * Release v10.0.1 --------- Co-authored-by: Denys Bohdan <[email protected]> Co-authored-by: Dmytro-Melnyshyn <[email protected]> Co-authored-by: Oleksandr Hladchenko <[email protected]>
Purpose
Approach
Refs
UIIN-2600
Screenshots
UIIN-2600.mp4