Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2588: Edit instance success toast no longer shows the instance HRID #2313

Merged
merged 2 commits into from
Oct 18, 2023
Merged

UIIN-2588: Edit instance success toast no longer shows the instance HRID #2313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e03afa8
UIIN-2588: Edit instance success toast no longer shows the instance HRID
mariia-aloshyna Oct 17, 2023
f304e58
Merge branch 'master' into UIIN-2588
mariia-aloshyna Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* Instance 3rd pane: Adjust behavior when returning to instance from holdings/item full screen. Refs UIIN-2453.
* Consortial holdings accordion is not appearing after the sharing of Instance. Fixes UIIN-2629.
* Reset CheckboxFacet state.more when user resets search form and fewer facet options are loaded. Fixes UIIN-2531.
* Edit instance success toast no longer shows the instance HRID. Fixes UIIN-2588.

## [10.0.0](https://github.com/folio-org/ui-inventory/tree/v10.0.0) (2023-10-13)
[Full Changelog](https://github.com/folio-org/ui-inventory/compare/v9.4.12...v10.0.0)
Expand Down
4 changes: 2 additions & 2 deletions src/Instance/InstanceEdit/InstanceEdit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ const InstanceEdit = ({

const goBack = useGoBack(`/inventory/view/${instanceId}`);

const onSuccess = useCallback((updatedInstance) => {
const onSuccess = useCallback(() => {
const message = instance?.shared ? (
<FormattedMessage id="ui-inventory.instance.shared.successfulySaved" />
) : (
<FormattedMessage
id="ui-inventory.instance.successfullySaved"
values={{ hrid: updatedInstance.hrid }}
values={{ hrid: instance.hrid }}
/>
);

Expand Down