Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-2634: Set tenant from stripes.okapi.tenant if location.state is empty (follow-up) #2323

Merged
merged 10 commits into from
Oct 31, 2023
Merged

UIIN-2634: Set tenant from stripes.okapi.tenant if location.state is empty (follow-up) #2323

merged 10 commits into from
Oct 31, 2023

Conversation

OleksandrHladchenko1
Copy link
Contributor

@OleksandrHladchenko1 OleksandrHladchenko1 commented Oct 27, 2023 •
edited
Loading

Purpose

Approach

  • Move manifest from ItemRoute to ItemView component in order to pass !{tenantTo} value
  • Added tenantTo prop to ViewHoldingsRecord component to simplify reading tenant field in manifest

Refs

UIIN-2634

Screenshots

@github-actions
Copy link

github-actions bot commented Oct 27, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0  226 suites  ±0   13m 25s ⏱️ -2s
888 tests ±0  886 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
893 runs  ±0  891 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 894fb8c. ± Comparison against base commit 921d93d.

♻️ This comment has been updated with latest results.

mariia-aloshyna
mariia-aloshyna requested changes Oct 27, 2023
View reviewed changes
src/ViewHoldingsRecord.js Outdated Show resolved Hide resolved
vashjs
vashjs approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@vashjs vashjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Changelog.md

@OleksandrHladchenko1
Copy link
Contributor Author

OleksandrHladchenko1 commented Oct 31, 2023 •
edited
Loading

Please update Changelog.md

It's follow-up change. CHANGELOG was already updated

@mariia-aloshyna
Copy link
Contributor

Fix code smell please

@mariia-aloshyna mariia-aloshyna self-requested a review October 31, 2023 10:33
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

41.2% 41.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 3d7c603 into master Oct 31, 2023
3 of 4 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIIN-2634 branch October 31, 2023 10:53
mariia-aloshyna pushed a commit that referenced this pull request Nov 7, 2023
@OleksandrHladchenko1 @mariia-aloshyna
UIIN-2634: Set tenant from stripes.okapi.tenant if location.state…
aa913ef 
… is empty (follow-up) (#2323)

* UIIN-2634: Remove error when search for an item

* UIIN-2634: Fix tests

* UIIN-2634: set tenant from stripes.okapi.tenant if location.state is empty

* Set !{tenantTo} instead of !{location.state.tenantTo} in holdings/items manifest

* UIIN-2634: Remove unused methods in ItemRoute component

* UIIN-2634: Fix code smell

* UIIN-2634: get rid of getRequestsPath variable

(cherry picked from commit 3d7c603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vashjs vashjs vashjs approved these changes

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @mariia-aloshyna @vashjs